Print non-extension fields by field number order instead of .proto file order. #16306
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Print non-extension fields by field number order instead of .proto file order.
This will affect both JSON and TextFormat. The serialization order for these two formats is not specified, so switching from
.proto
file order to field number order should not be breaking.This does not affect the order of extensions, which are always printed last (even if their field numbers interleave with regular fields.
This change appears to speed up JSON encoding by about 15%: