Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7392] fix conformance test in PHP JSON parser #16743

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[7392] fix conformance test in PHP JSON parser #16743

wants to merge 1 commit into from

Conversation

antongrbin
Copy link
Contributor

@antongrbin antongrbin commented May 4, 2024 •
edited
Loading

Motivation

This PR fixes failing JSON conformance tests for php with name IgnoreUnknownEnumStringValue*.

The JSON parsing spec was discussed in #7392.

Recent similar changes in other languages:

@antongrbin antongrbin force-pushed the anton--7392--fix-unknown-enum-php branch 2 times, most recently from 0498647 to 77bb25f Compare June 13, 2024 17:49
@antongrbin antongrbin marked this pull request as ready for review June 13, 2024 17:51
@antongrbin antongrbin requested a review from a team as a code owner June 13, 2024 17:51
@antongrbin antongrbin force-pushed the anton--7392--fix-unknown-enum-php branch from 77bb25f to 367aa3d Compare June 13, 2024 17:51
@antongrbin antongrbin requested review from a team as code owners June 13, 2024 17:51
@antongrbin
Copy link
Contributor Author

@jskeet, since you worked with me on the linked issue #7392, is it OK to ask you to help me find a PHP reviewer to move this forward?

@bshaffer
Copy link
Contributor

@antongrbin I can take a look

@antongrbin
Copy link
Contributor Author

@bshaffer thank you for the review offer && polite ping :)

@antongrbin
Copy link
Contributor Author

@bshaffer friendly ping :)

@JasonLunn JasonLunn added the php label Oct 11, 2024
@JasonLunn JasonLunn added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Oct 11, 2024
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Oct 11, 2024
bshaffer
bshaffer reviewed Oct 11, 2024
View reviewed changes
Copy link
Contributor

@bshaffer bshaffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really the behavior we want? If an array/map is unknown, it throws an exception unless other valid values exist, at which point the unknown value is ignored?

That does not seem like intuitive behavior to me... what is the justification for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bshaffer bshaffer bshaffer left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
php wait for user action
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@antongrbin @bshaffer @JasonLunn @zhangskz