Fix minor typos #17682

NathanBaulch · 2024-08-01T04:52:04Z

Just thought I'd contribute some typo fixes that keep tripping up CI/CD checks in my projects. Nothing controversial (hopefully), just 174 simple fixes.

Use the following command to get a quick and dirty summary of the specific corrections made:

git diff HEAD^! --word-diff-regex='\w+' -U0 \
  | grep -E '\[\-.*\-\]\{\+.*\+\}' \
  | sed -r 's/.*\[\-(.*)\-\]\{\+(.*)\+\}.*/\1 \2/' \
  | sort | uniq -c | sort -n

FWIW, the top typos are:

trimed → trimmed (37)
substract → subtract (7)
qualifed → qualified (7)
extesion → extension (6)
mising → missing (5)
btye → byte (4)
likey → likely (4)
candicate → candidate (3)
decriptor → descriptor (3)
inherting → inheriting (3)
colletion → collection (3)
caluclated → calculated (3)
unititialized → uninitialized (3)
implemting → implementing (3)
binrary → binary (3)
descripor → descriptor (3)
negitive → negative (3)

google-cla · 2024-08-01T04:52:08Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

jskeet

The C# changes look fine to me.

JasonLunn

Ruby changes LGTM

JasonLunn · 2024-08-05T14:36:26Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@NathanBaulch Please sign the CLA as soon as possible.

NathanBaulch · 2024-08-05T21:20:16Z

@NathanBaulch Please sign the CLA as soon as possible.

I signed it last week shortly after creating this PR @JasonLunn. NVM, just found the refresh link.

NathanBaulch · 2024-08-09T11:24:53Z

Sorry @JasonLunn, I force pushed to resolve a new conflict with main and lost the "safe for tests" status.

NathanBaulch · 2024-09-03T11:23:36Z

Bump!

tonyliaoss · 2024-09-20T16:11:46Z

Hi Nathan, sorry for the late response, unfortunately it looks like there are new merge conflicts from some of the files going stale. Could you pull up to main and resolve the merge conflicts please?

mkruskal-google · 2024-09-20T16:26:39Z

src/google/protobuf/descriptor.proto

@@ -80,7 +80,7 @@ enum Edition {
  EDITION_2024 = 1001;

  // Placeholder editions for testing feature resolution.  These should not be
-  // used or relyed on outside of tests.


Unfortunately we can't accept any external contributions to this file

Ah, this particular typo is what started this whole process for me! It leaks into downstream code that references google/api/annotations.proto, typically to annotate services with HTTP routing metadata.
If someone internal could "independently" fix this typo then that'd be great! 🙏

mkruskal-google · 2024-09-20T17:05:20Z

src/google/protobuf/api.proto

@@ -166,7 +166,7 @@ message Method {
 // The mixin construct implies that all methods in `AccessControl` are
 // also declared with same name and request/response types in
 // `Storage`. A documentation generator or annotation processor will
-// see the effective `Storage.GetAcl` method after inherting


Similar issue here, our policies don't allow us to accept external contributions to this file, so I'm removing it on the import

Just thought I'd contribute some typo fixes that keep tripping up CI/CD checks in my projects. Nothing controversial (hopefully), just 174 simple fixes. Use the following command to get a quick and dirty summary of the specific corrections made: ```shell git diff HEAD^! --word-diff-regex='\w+' -U0 \ | grep -E '\[\-.*\-\]\{\+.*\+\}' \ | sed -r 's/.*\[\-(.*)\-\]\{\+(.*)\+\}.*/\1 \2/' \ | sort | uniq -c | sort -n ``` FWIW, the top typos are: * trimed → trimmed (37) * substract → subtract (7) * qualifed → qualified (7) * extesion → extension (6) * mising → missing (5) * btye → byte (4) * likey → likely (4) * candicate → candidate (3) * decriptor → descriptor (3) * inherting → inheriting (3) * colletion → collection (3) * caluclated → calculated (3) * unititialized → uninitialized (3) * implemting → implementing (3) * binrary → binary (3) * descripor → descriptor (3) * negitive → negative (3) Closes #17682 COPYBARA_INTEGRATE_REVIEW=#17682 from NathanBaulch:typos d41762d FUTURE_COPYBARA_INTEGRATE_REVIEW=#17682 from NathanBaulch:typos d41762d PiperOrigin-RevId: 676872471

tonyliaoss · 2024-09-20T18:14:17Z

Hi Nathan,

We are going to do a force-pull and resolve those conflicts ourselves. No action needed on your part.

Just thought I'd contribute some typo fixes that keep tripping up CI/CD checks in my projects. Nothing controversial (hopefully), just 174 simple fixes. Use the following command to get a quick and dirty summary of the specific corrections made: ```shell git diff HEAD^! --word-diff-regex='\w+' -U0 \ | grep -E '\[\-.*\-\]\{\+.*\+\}' \ | sed -r 's/.*\[\-(.*)\-\]\{\+(.*)\+\}.*/\1 \2/' \ | sort | uniq -c | sort -n ``` FWIW, the top typos are: * trimed → trimmed (37) * substract → subtract (7) * qualifed → qualified (7) * extesion → extension (6) * mising → missing (5) * btye → byte (4) * likey → likely (4) * candicate → candidate (3) * decriptor → descriptor (3) * inherting → inheriting (3) * colletion → collection (3) * caluclated → calculated (3) * unititialized → uninitialized (3) * implemting → implementing (3) * binrary → binary (3) * descripor → descriptor (3) * negitive → negative (3) Closes #17682 COPYBARA_INTEGRATE_REVIEW=#17682 from NathanBaulch:typos d41762d FUTURE_COPYBARA_INTEGRATE_REVIEW=#17682 from NathanBaulch:typos d41762d PiperOrigin-RevId: 676872471

NathanBaulch · 2024-09-20T20:25:59Z

No worries @tonyliaoss, let me know if you need anything.

Just thought I'd contribute some typo fixes that keep tripping up CI/CD checks in my projects. Nothing controversial (hopefully), just 174 simple fixes. Use the following command to get a quick and dirty summary of the specific corrections made: ```shell git diff HEAD^! --word-diff-regex='\w+' -U0 \ | grep -E '\[\-.*\-\]\{\+.*\+\}' \ | sed -r 's/.*\[\-(.*)\-\]\{\+(.*)\+\}.*/\1 \2/' \ | sort | uniq -c | sort -n ``` FWIW, the top typos are: * trimed → trimmed (37) * substract → subtract (7) * qualifed → qualified (7) * extesion → extension (6) * mising → missing (5) * btye → byte (4) * likey → likely (4) * candicate → candidate (3) * decriptor → descriptor (3) * inherting → inheriting (3) * colletion → collection (3) * caluclated → calculated (3) * unititialized → uninitialized (3) * implemting → implementing (3) * binrary → binary (3) * descripor → descriptor (3) * negitive → negative (3) Closes #17682 COPYBARA_INTEGRATE_REVIEW=#17682 from NathanBaulch:typos d41762d FUTURE_COPYBARA_INTEGRATE_REVIEW=#17682 from NathanBaulch:typos d41762d PiperOrigin-RevId: 676872471

NathanBaulch requested review from a team as code owners August 1, 2024 04:52

NathanBaulch requested review from acozzette, ericsalo and dmaclach and removed request for a team August 1, 2024 04:52

NathanBaulch requested review from shaod2 and jskeet and removed request for a team August 1, 2024 04:52

jskeet reviewed Aug 1, 2024

View reviewed changes

JasonLunn added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Aug 5, 2024

github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Aug 5, 2024

JasonLunn reviewed Aug 5, 2024

View reviewed changes

NathanBaulch force-pushed the typos branch from 1d7e193 to 52c6368 Compare August 7, 2024 03:41

NathanBaulch mentioned this pull request Aug 7, 2024

Fix minor typos grpc/grpc-proto#158

Merged

NathanBaulch force-pushed the typos branch from 52c6368 to 61c4c35 Compare August 13, 2024 23:14

Fix typos

d41762d

NathanBaulch force-pushed the typos branch from 61c4c35 to d41762d Compare August 18, 2024 21:23

JasonLunn added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Aug 19, 2024

github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Aug 19, 2024

JasonLunn approved these changes Sep 3, 2024

View reviewed changes

mkruskal-google reviewed Sep 20, 2024

View reviewed changes

copybara-service bot mentioned this pull request Sep 20, 2024

Fix minor typos (#17682) #18455

Merged

copybara-service bot closed this in e4cbc79 Sep 21, 2024

NathanBaulch deleted the typos branch September 21, 2024 03:54

protobuf-team-bot added a commit that referenced this pull request Sep 21, 2024

Auto-generate files after PR #17682

ecf5f2e

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix minor typos #17682

Fix minor typos #17682

NathanBaulch commented Aug 1, 2024 •

edited

Loading

google-cla bot commented Aug 1, 2024

jskeet left a comment

JasonLunn left a comment

JasonLunn commented Aug 5, 2024

NathanBaulch commented Aug 5, 2024 •

edited

Loading

NathanBaulch commented Aug 9, 2024

NathanBaulch commented Sep 3, 2024

tonyliaoss commented Sep 20, 2024

mkruskal-google Sep 20, 2024

NathanBaulch Sep 20, 2024

mkruskal-google Sep 20, 2024

tonyliaoss commented Sep 20, 2024

NathanBaulch commented Sep 20, 2024

Fix minor typos #17682

Fix minor typos #17682

Conversation

NathanBaulch commented Aug 1, 2024 • edited Loading

google-cla bot commented Aug 1, 2024

jskeet left a comment

Choose a reason for hiding this comment

JasonLunn left a comment

Choose a reason for hiding this comment

JasonLunn commented Aug 5, 2024

NathanBaulch commented Aug 5, 2024 • edited Loading

NathanBaulch commented Aug 9, 2024

NathanBaulch commented Sep 3, 2024

tonyliaoss commented Sep 20, 2024

mkruskal-google Sep 20, 2024

Choose a reason for hiding this comment

NathanBaulch Sep 20, 2024

Choose a reason for hiding this comment

mkruskal-google Sep 20, 2024

Choose a reason for hiding this comment

tonyliaoss commented Sep 20, 2024

NathanBaulch commented Sep 20, 2024

NathanBaulch commented Aug 1, 2024 •

edited

Loading

NathanBaulch commented Aug 5, 2024 •

edited

Loading