Cherry pick changes to drop Java pom.xml files unused for release. #17728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to test our maven setup without relying on static `pom.xml` files and clears the way to remove them in a subsequent CL. PiperOrigin-RevId: 658057911
This will cause the script to fail if any command fails, which will make it easier to debug failures. PiperOrigin-RevId: 658878371
We mostly use generated pom files in our release currently, so we can delete all the files that aren't used and the tools to update them. Note, java/bom/pom.xml java/pom.xml and java/protoc/pom.xml are all still used at release and java/kotlin/pom.xml is used for documentation so all of those need to stay for now. PiperOrigin-RevId: 659664012
zhangskz
requested review from
acozzette and
googleberg
and removed request for
a team and
acozzette
deannagarcia
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This drops support for building Protobuf Java from source with Maven per https://protobuf.dev/news/2024-06-26/
Cherry-pick of commits 7c93804, 8714892 and f5ffaf9