Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move -Werror to our test/dev bazelrc files. #17939

Merged
merged 6 commits into from
Aug 23, 2024
Merged

Move -Werror to our test/dev bazelrc files. #17939

merged 6 commits into from
Aug 23, 2024

Commits on Aug 23, 2024

  1. Move -Werror to our test/dev bazelrc files. 

    Putting it into BUILD files unintentionally forces it on all our downstream users.  Instead, we just want to enable this during testing and let them choose for themselves in their builds.

Note, that this expands the scope of -Werror to our entire repo for CI, so a bunch of fixes and opt-outs had to be applied to get this change passing.

Closed #14714

PiperOrigin-RevId: 666903224
    @mkruskal-google
    mkruskal-google committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    ef4048d View commit details
    Browse the repository at this point in the history

  2. Fix extra warnings on 27.x

    @mkruskal-google
    mkruskal-google committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    7f4f6fa View commit details
    Browse the repository at this point in the history

  3. Fix zlib issues on macos

    @mkruskal-google
    mkruskal-google committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    395018f View commit details
    Browse the repository at this point in the history

  4. Fix spurious upb warnings in 27.x

    @mkruskal-google
    mkruskal-google committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    21bccd2 View commit details
    Browse the repository at this point in the history

  5. Second try at zlib/macos issues

    @mkruskal-google
    mkruskal-google committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    9fdd6a5 View commit details
    Browse the repository at this point in the history

  6. Only disable deprecated-non-prototype on macos-14

    @mkruskal-google
    mkruskal-google committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    ea66096 View commit details
    Browse the repository at this point in the history