Remove calls to TestTmpDir in protobuf/testing/googletest.cc. #18348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_675307746
branch
7 times, most recently
from
cf52975
to
b3bfd46
Compare
This came up as a pull request here: #18239. |tmpnam| is ugly and would be nice to avoid. We don't necessarily want to substitute out GetTemporaryDirectoryName with |std::filesystem::temp_directory_path| -- the current setup creates a subdirectory under the tmp directory and uses TempDirDeleter to clean it up. We want to preserve that behaviour: the current setup plays nicely with bazel without polluting /tmp with unbounded growth. #test-continuous PiperOrigin-RevId: 677843997
copybara-service
bot
force-pushed
the
test_675307746
branch
from
b3bfd46
to
86874ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove calls to TestTmpDir in protobuf/testing/googletest.cc.
This came up as a pull request here:
#18239.
While we can't use |std::filesystem::temp_directory_path| as suggested due to the
need to support C++14 until 2024-12-15, we might be able to get rid of the
implementation of TestTmpDir directly and just use testing::TmpDir() as
implemented by GoogleTest.