Rust: introduce trait for access to message default instances #18436
+32
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
The immediate motivation for this is that it will facilitate writing a blanket implementation of `ProxiedInMapValue` for C++-backed messages. The default instance gives us access to the message vtable in cases where we don't already have a message to work with. It also seems useful for code that just needs a static-lifetime empty view, though, so I implemented it for upb messages as well. PiperOrigin-RevId: 676509188
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rust: introduce trait for access to message default instances
The immediate motivation for this is that it will facilitate writing a blanket
implementation of
ProxiedInMapValuefor C++-backed messages. The defaultinstance gives us access to the message vtable in cases where we don't already
have a message to work with.
It also seems useful for code that just needs a static-lifetime empty view,
though, so I implemented it for upb messages as well.