Rust: move proxy implementations of AssociatedMiniTable into the runtime #19204
+40
−65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
We are currently generating separate implementations of the `AssociatedMiniTable` trait for owned messages, view proxies, and mutable proxies. I don't think this is really necessary, though, because once we have an implementation for one of these, we can derive it for the other two. This CL deletes the proxy implementations from the generated code and adds a blanket implementation to replace them. This is not super important, but it seems nice to reduce our reliance on generated code a little bit. PiperOrigin-RevId: 694680222
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rust: move proxy implementations of AssociatedMiniTable into the runtime
We are currently generating separate implementations of the
AssociatedMiniTabletrait for owned messages, view proxies, and mutableproxies. I don't think this is really necessary, though, because once we have
an implementation for one of these, we can derive it for the other two.
This CL deletes the proxy implementations from the generated code and adds a
blanket implementation to replace them. This is not super important, but it
seems nice to reduce our reliance on generated code a little bit.