Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenShift route Helm Chart parameters configuration #3778

Merged
merged 1 commit into from
May 11, 2023

Conversation

rmarting
Copy link

@rmarting rmarting commented May 4, 2023

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)

This PR is created to support the enhacement identified in the provectus/kafka-ui-charts#4. It is an initial approach to cover that feature for OpenShift environments. This PR is a complementary for the #3777 to add the documentation of the new parameters to cover that new feature.

Is there anything you'd like reviewers to focus on?

This PR should be accepted and merged after the #3777 is merged into the master branch.

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@Haarolean Haarolean requested a review from a team May 9, 2023 08:59
@Haarolean Haarolean added type/documentation Improvements or additions to documentation scope/k8s K8s or helm stuff (really annoying) labels May 9, 2023
@Haarolean Haarolean merged commit ffb99f0 into provectus:docs May 11, 2023
@Haarolean
Copy link
Contributor

@rmarting thank you

@rmarting rmarting deleted the feature/docs-ocp-route branch May 12, 2023 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope/k8s K8s or helm stuff (really annoying) type/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants