Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix groups proposal error #504

Merged
merged 3 commits into from
Nov 14, 2023

Conversation

nullpointer0x00
Copy link
Contributor

@nullpointer0x00 nullpointer0x00 commented Nov 9, 2023

Description

There was a filtering of transactions that were not from the groups module and it would lose the index of the required event log index. Fixed by returning a tuple with the expected index.

closes: #499


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit and integration
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@nullpointer0x00
Copy link
Contributor Author

I deployed this fix to testnet and re-ran a total of 1022 blocks worth of transaction processing. This fixed them all.

Here is a link from the #499 example error at block: 18607185 https://explorer.test.provenance.io/block/18607185

@nullpointer0x00 nullpointer0x00 marked this pull request as ready for review November 14, 2023 19:16
@nullpointer0x00 nullpointer0x00 requested a review from a team as a code owner November 14, 2023 19:17
@nullpointer0x00 nullpointer0x00 requested a review from a team November 14, 2023 19:17
@nullpointer0x00 nullpointer0x00 self-assigned this Nov 14, 2023
@nullpointer0x00 nullpointer0x00 added the bug Something isn't working label Nov 14, 2023
@nullpointer0x00 nullpointer0x00 added this to the v5.7.0 milestone Nov 14, 2023
@nullpointer0x00 nullpointer0x00 merged commit f9f94c4 into main Nov 14, 2023
4 checks passed
@nullpointer0x00 nullpointer0x00 deleted the nullpointer0x00/499-error-saving-groups-from-tx branch November 14, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging this pull request may close these issues.

Error saving groups from transaction
2 participants