Provenance Pulse Endpoints #595
Conversation
|
|
||
| /** | ||
| * Note that `denom` is a required request param instead of a path variable | ||
| * because denoms like `nft/blahblahblah` exist and are not valid path variables. |
There was a problem hiding this comment.
see also: all the ibc denoms... these caused the REST apis to break a long time ago...
| AccountRecord.find { | ||
| (AccountTable.isContract eq Op.FALSE) and | ||
| (AccountTable.baseAccount.isNotNull()) and | ||
| (AccountTable.type eq "BaseAccount") |
There was a problem hiding this comment.
Are all accounts base accounts? I'm still catching up on the hierarchy of base, vest, marker, etc...
There was a problem hiding this comment.
Yes. Base account is the bottom. A single extension class can extend/derive from it and add more fields. I’ve heard the sdk team plans to undo all of that at some point which would be an extremely disruptive set of changes I fear.
| @@ -151,19 +149,19 @@ class TxCacheRecord(id: EntityID<Int>) : IntEntity(id) { | |||
| var join: ColumnSet = TxCacheTable | |||
|
|
|||
| if (tqp.msgTypes.isNotEmpty()) { | |||
| join = join.innerJoin(TxMsgTypeQueryTable, { TxCacheTable.id }, { TxMsgTypeQueryTable.txHashId }) | |||
| join = join.innerJoin(TxMsgTypeQueryTable, { TxCacheTable.id }, { txHashId }) | |||
There was a problem hiding this comment.
thx for fixing these as you went through. They were making my brain hurt.
| }.build() | ||
| ).market | ||
|
|
||
| suspend fun getMarketBriefsByDenom(denom: String): List<MarketBrief> = exchangeClient.getAllMarkets( |
There was a problem hiding this comment.
not sure how we typically order function, but I'm a fan of least protected to most protected, or pub to priv. Your org is fine to me, just curious what our standard should be going forward, or if we even want one.
There was a problem hiding this comment.
I try to group by "locality of behavior" but that often just turns into last written, last function.
| @@ -388,4 +393,9 @@ class ScheduledTaskService( | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| @Scheduled(initialDelay = 1L, fixedDelay = 5L, timeUnit = TimeUnit.MINUTES) | |||
There was a problem hiding this comment.
at some point, I'd like to see these scheduled tasks broken up into separate files rather than one huge ScheduledTaskService. There is just too much going on in that service to know the scope of a change. This addition is fine for now though, just future thought.
Description
Adds endpoints for the new Provenance Pulse web application https://test.provenance.io/pulse.
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes