Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pulse Asset Value Calculation Tweaks, Mild Code Reformatting #596

Merged
merged 2 commits into from
Feb 28, 2025

Conversation

jdfigure
Copy link
Member

Description

  • Use 3 decimals for metadata NAV events when calculating USD value
  • Get the exchange module-based price when valuing committed assets and
    ensure denom metadata is used to calculate the denom's volume.
  • Re-ordered priv/pub functions in Pulse service

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit and integration
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@jdfigure jdfigure requested a review from a team as a code owner February 27, 2025 21:02
@jdfigure jdfigure merged commit 0eefa8d into main Feb 28, 2025
3 checks passed
@jdfigure jdfigure deleted the jd/pulse-value-tweaks branch February 28, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants