-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GetByAddr and smaller metadata queries. #1614
Conversation
… flags to relevant queries.
…mBech32 so the hrp can be returned too.
…E in the all queries from the IncludeIdInfo flags.
…quest instead of just a CLI thing.
…tor the get command to use the new GetByAddr endpoint.
…failing with recent changes.
…point just in case.
…aAddressFromBech32.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1614 +/- ##
==========================================
+ Coverage 63.61% 63.83% +0.21%
==========================================
Files 223 223
Lines 28493 28599 +106
==========================================
+ Hits 18127 18256 +129
+ Misses 9179 9152 -27
- Partials 1187 1191 +4
|
# Conflicts: # CHANGELOG.md
…ocessing capabilites of the node decide the max just like how all the other paginated queries work.
# Conflicts: # CHANGELOG.md
seems like a pretty elegant solution ... I do wonder if this should be "exclude_extra_info" since the default for proto is null/zero so in this case the default behavior would be the existing one and the opt-in would be the streamlined results? This would give smart contract authors the option of streamlining the results if they are able but would keep existing workflows working without changes... |
I'm assuming we don't have any smart contracts dealing with metadata yet since most of that stuff is missing from the x/metadata/wasm directory. But this would break anything else that runs the queries and expects the I primarily wanted to, by default, shrink the size of the responses. I also wanted to stick with the I do have an entry under The more I think about it, though, the more I think you're right. I'll switch it to |
…otos, and regen them. Also update the spec to reflect that.
…luce_id_info flag.
# Conflicts: # CHANGELOG.md # client/docs/statik/statik.go
Description
closes: #1443
This PR:
include_request
flag to appropriate metadata queries. The request is only included in the response if set totrue
. This info was previously always included, so this is a breaking change.exclude_id_info
flag to appropriate metadata queries. If set to true, the*_id_info
fields in the response will not be populated.GetByAddr
endpoint that takes in one or more metadata addresses and returns all the requested items. Thequery metadata get
command has been overhauled to utilize this query instead of each individual type query.Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes