Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change resource-id type to AccAddress #1647

Merged
merged 4 commits into from
Aug 11, 2023
Merged

Change resource-id type to AccAddress #1647

merged 4 commits into from
Aug 11, 2023

Conversation

iramiller
Copy link
Member

@iramiller iramiller commented Aug 10, 2023

Description

Change the type cast on resource-id of a contract specification to AccAddress from MetadataAddress. This allows the resource-id to properly reference smart contract addresses on chain.

closes: #1646


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@iramiller iramiller added bug Something isn't working metadata Metadata Module labels Aug 10, 2023
@iramiller iramiller added this to the v1.17.0 milestone Aug 10, 2023
@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Merging #1647 (6048273) into main (7835092) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1647      +/-   ##
==========================================
- Coverage   63.61%   63.60%   -0.02%     
==========================================
  Files         223      223              
  Lines       28493    28493              
==========================================
- Hits        18127    18122       -5     
- Misses       9179     9183       +4     
- Partials     1187     1188       +1     
Files Changed Coverage Δ
x/metadata/client/cli/tx.go 76.81% <100.00%> (-0.49%) ⬇️
x/metadata/types/specification.go 98.87% <100.00%> (ø)

@iramiller iramiller marked this pull request as ready for review August 10, 2023 22:39
@iramiller iramiller requested a review from a team as a code owner August 10, 2023 22:39
@iramiller iramiller self-assigned this Aug 10, 2023
@iramiller iramiller merged commit 294259a into main Aug 11, 2023
41 checks passed
@iramiller iramiller deleted the iramiller/issue1646 branch August 11, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working metadata Metadata Module
Projects
Development

Successfully merging this pull request may close these issues.

Metadata specifications use wrong address type on resources
3 participants