Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable INFO level logging for keripy witnesses #2

Merged
merged 3 commits into from
Feb 19, 2024
Merged

Conversation

rubelhassan
Copy link

keripy INFO level logs cover most of the cases.

hio.help.ogling module provides Ogler class for global logging in keripy. The class can print log to

  • console
  • syslog
  • file

keripy INFO level logs cover most of the cases.

hio.help.ogling module provides Ogler class for global logging in keripy. The class can print log to

- console
- syslog
- file
@rubelhassan
Copy link
Author

@dhh1128 @Arsh-Sandhu @s-a-tanjim I've enabled INFO level logging for Keripy which logs most of the cases of witness interactions. Please suggest any important events you think are necessary to log, and I'll add logs for them.

@rubelhassan
Copy link
Author

As discussed with Shoeb console base logging is sufficient for now.

Copy link
Member

@dhh1128 dhh1128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@s-a-tanjim
Copy link
Member

@rubelhassan I made small changes on top of your work. Can you please review it: #3

Make log level configurable from command line argument
@dhh1128 dhh1128 merged commit 43c2756 into prod Feb 19, 2024
5 checks passed
@s-a-tanjim s-a-tanjim deleted the HSS-110-Witness-Log branch February 19, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants