SRU2024 v10 #190
SRU2024 v10 #190
Conversation
WalkthroughWalkthroughThe recent updates primarily involve migrating the codebase from Java 8 and the Changes
Sequence Diagram(s)The changes mainly involve codebase migration, updates, and bug fixes, which do not warrant a sequence diagram as they don’t introduce new control flows or functionalities requiring visualization. Recent review detailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Additional context usedLanguageTool
Markdownlint
Additional comments not posted (13)
Tip Early access features
Note:
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 9
Outside diff range comments (10)
CHANGELOG.md (10)
Line range hint
75-75: Consider using an en dash for the date range in the heading for clarity and consistency.-#### 9.3.15 - May 2023 +#### 9.3.15 – May 2023
Line range hint
77-77: Consider using a more concise expression to improve readability.-Added distinguishedName(boolean includeDefaultBranch) method to BIC in order to return default branch name +Added distinguishedName(boolean includeDefaultBranch) method to BIC to return default branch name
Line range hint
79-79: Consider using an en dash for the date range in the heading for clarity and consistency.-#### 9.3.14 - March 2023 +#### 9.3.14 – March 2023
Line range hint
81-81: Consider using a more concise expression to improve readability.-Added addUnstructuredStrict method to Narrative in order to strictly wrap unstructured input +Added addUnstructuredStrict method to Narrative to strictly wrap unstructured input
Line range hint
83-83: Consider using an en dash for the date range in the heading for clarity and consistency.-#### 9.3.13 - March 2023 +#### 9.3.13 – March 2023
Line range hint
86-86: Consider using an en dash for the date range in the heading for clarity and consistency.-#### 9.3.12 - February 2023 +#### 9.3.12 – February 2023
Line range hint
92-92: Consider using an en dash for the date range in the heading for clarity and consistency.-#### 9.3.11 - January 2023 +#### 9.3.11 – January 2023
Line range hint
96-96: Consider using an en dash for the date range in the heading for clarity and consistency.-#### 9.3.10 - January 2023 +#### 9.3.10 – January 2023
Line range hint
101-101: Consider using a more concise expression to improve readability.-StructuredNarrative: Added getBankCode() methods in order to allow direct access to data (used in SCORE messages) +StructuredNarrative: Added getBankCode() methods to allow direct access to data (used in SCORE messages)
Line range hint
114-114: Consider using a more concise expression to improve readability.-Added removeRepeatedBoundaries method in order to remove repeated tag boundaries +Added removeRepeatedBoundaries method to remove repeated tag boundaries
| import jakarta.persistence.*; | ||
| import jakarta.xml.bind.annotation.XmlTransient; |
There was a problem hiding this comment.
Tip
Codebase Verification
The migration from javax to jakarta is incomplete. The following files still contain javax references and need to be updated:
src/test/java/com/prowidesoftware/swift/utils/SafeXmlUtilsTest.java- Lines: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10
src/test/java/com/prowidesoftware/swift/io/parser/XMLParserTest.java- Line: 1
src/main/java/com/prowidesoftware/swift/utils/SafeXmlUtils.java- Lines: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19
src/main/java/com/prowidesoftware/swift/io/parser/XMLParser.java- Line: 1
Please update these references to use the jakarta namespace.
Analysis chain
Migration from javax to jakarta namespaces is correctly implemented in the imports.
Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify that there are no remaining `javax` references in the project.
# Test: Search for `javax` usage. Expect: No occurrences.
rg --type java 'javax'
Length of output: 2734
| * (PW-1697) Fixed validation/parse pattern in field 29O | ||
| * (PW-1697) MT306 changes in field 30I | ||
| * Added DistinguishedName with Builder in order to encapsulate the BIC branch name logic | ||
|
|
||
| #### 9.4.12 - November 2023 | ||
| #### 10.1.11 - November 2023 |
There was a problem hiding this comment.
Consider using an en dash for the date range in the heading for clarity and consistency.
-#### 10.1.11 - November 2023
+#### 10.1.11 – November 2023Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| #### 10.1.11 - November 2023 | |
| #### 10.1.11 – November 2023 |
| * (PW-1697) Fixed validation pattern in fields 14[H,K,L,M,N,O] and 29J | ||
|
|
||
| #### 9.4.11 - November 2023 | ||
| #### 10.1.10 - November 2023 |
There was a problem hiding this comment.
Consider using an en dash for the date range in the heading for clarity and consistency.
-#### 10.1.10 - November 2023
+#### 10.1.10 – November 2023Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| #### 10.1.10 - November 2023 | |
| #### 10.1.10 – November 2023 |
| * (PW-1862) Added NarrativeFragment class for detailed line information in StructuredNarrative fragments | ||
| * Fixed SwiftMessage getPDE(): return empty value instead of null when codeword exists and has no value | ||
| * Added isPercentage() helper method to field 37K | ||
|
|
||
| #### 9.4.15 - March 2024 | ||
| #### 10.1.14 - March 2024 |
There was a problem hiding this comment.
Consider using an en dash for the date range in the heading for clarity and consistency.
-#### 10.1.14 - March 2024
+#### 10.1.14 – March 2024Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| #### 10.1.14 - March 2024 | |
| #### 10.1.14 – March 2024 |
| * (PW-1812) Updated the narrative resolver, format 2 (used in field 72 for example), to allow empty values as part of the narrative fragment | ||
| * Updated validators for BIC, country, and currency constraints to utilize keywords for i18n-compatible messages | ||
| * Deprecated unnecessary methods in the SafeXmlUtils class | ||
|
|
||
| #### 9.4.14 - December 2023 | ||
| #### 10.1.13 - December 2023 |
There was a problem hiding this comment.
Consider using an en dash for the date range in the heading for clarity and consistency.
-#### 10.1.13 - December 2023
+#### 10.1.13 – December 2023Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| #### 10.1.13 - December 2023 | |
| #### 10.1.13 – December 2023 |
|
|
||
| #### 9.4.16 - May 2024 | ||
| #### 10.1.15 - May 2024 |
There was a problem hiding this comment.
Consider using an en dash for the date range in the heading for clarity and consistency.
-#### 10.1.15 - May 2024
+#### 10.1.15 – May 2024Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| #### 10.1.15 - May 2024 | |
| #### 10.1.15 – May 2024 |
| * (PW-1718) Changed the getComponentLabel(component) in Field59F to be dynamic based on the line identifiers (similar to existing API in Field50F) | ||
|
|
||
| #### 9.4.13 - November 2023 | ||
| #### 10.1.12 - November 2023 |
There was a problem hiding this comment.
Consider using an en dash for the date range in the heading for clarity and consistency.
-#### 10.1.12 - November 2023
+#### 10.1.12 – November 2023Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| #### 10.1.12 - November 2023 | |
| #### 10.1.12 – November 2023 |
| * (PW-1718) Changed the getComponentLabel(component) in Field59F to be dynamic based on the line identifiers (similar to existing API in Field50F) | ||
|
|
||
| #### 9.4.13 - November 2023 | ||
| #### 10.1.12 - November 2023 | ||
| * (PW-1697) Fixed validation/parse pattern in field 29O | ||
| * (PW-1697) MT306 changes in field 30I | ||
| * Added DistinguishedName with Builder in order to encapsulate the BIC branch name logic |
There was a problem hiding this comment.
Consider using a more concise expression to improve readability.
-Added DistinguishedName with Builder in order to encapsulate the BIC branch name logic
+Added DistinguishedName with Builder to encapsulate the BIC branch name logicCommittable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| * Added DistinguishedName with Builder in order to encapsulate the BIC branch name logic | |
| * Added DistinguishedName with Builder to encapsulate the BIC branch name logic |
| * Restore deprecated method in MT210 class | ||
|
|
||
| #### 9.5.0 - May 2024 | ||
| #### 10.2.0 - May 2024 |
There was a problem hiding this comment.
Consider using an en dash for the date range in the heading for clarity and consistency.
-#### 10.2.0 - May 2024
+#### 10.2.0 – May 2024Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| #### 10.2.0 - May 2024 | |
| #### 10.2.0 – May 2024 |
| * Added default methods for sender, receiver, and identifier extraction to the MessageExtractionStrategy | ||
| * Added JSON to the `FileFormat` enumeration |
There was a problem hiding this comment.
Fix the indentation of the list items.
The list items should be indented correctly for better readability.
- * Added default methods for sender, receiver, and identifier extraction to the MessageExtractionStrategy
- * Added JSON to the `FileFormat` enumeration
+* Added default methods for sender, receiver, and identifier extraction to the MessageExtractionStrategy
+* Added JSON to the `FileFormat` enumerationCommittable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| * Added default methods for sender, receiver, and identifier extraction to the MessageExtractionStrategy | |
| * Added JSON to the `FileFormat` enumeration | |
| * Added default methods for sender, receiver, and identifier extraction to the MessageExtractionStrategy | |
| * Added JSON to the `FileFormat` enumeration |
Tools
Markdownlint
46-46: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
47-47: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
46-46: null
Lists should be surrounded by blank lines(MD032, blanks-around-lists)
| * (PW-1812) Updated the narrative resolver, format 2 (used in field 72 for example), to allow empty values as part of the narrative fragment | ||
| * Updated validators for BIC, country, and currency constraints to utilize keywords for i18n-compatible messages | ||
| * Deprecated unnecessary methods in the SafeXmlUtils class | ||
|
|
||
| #### 9.4.14 - December 2023 | ||
| #### 10.1.13 - December 2023 | ||
| * (PW-1718) Changed the getComponentLabel(component) in Field59F to be dynamic based on the line identifiers (similar to existing API in Field50F) |
There was a problem hiding this comment.
Fix the indentation of the list item.
The list item should be indented correctly for better readability.
- * (PW-1718) Changed the getComponentLabel(component) in Field59F to be dynamic based on the line identifiers (similar to existing API in Field50F)
+* (PW-1718) Changed the getComponentLabel(component) in Field59F to be dynamic based on the line identifiers (similar to existing API in Field50F)Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| * (PW-1718) Changed the getComponentLabel(component) in Field59F to be dynamic based on the line identifiers (similar to existing API in Field50F) | |
| * (PW-1718) Changed the getComponentLabel(component) in Field59F to be dynamic based on the line identifiers (similar to existing API in Field50F) |
Tools
Markdownlint
24-24: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
24-24: null
Lists should be surrounded by blank lines(MD032, blanks-around-lists)
| * (PW-1697) Fixed validation/parse pattern in field 29O | ||
| * (PW-1697) MT306 changes in field 30I | ||
| * Added DistinguishedName with Builder in order to encapsulate the BIC branch name logic | ||
|
|
||
| #### 9.4.12 - November 2023 | ||
| #### 10.1.11 - November 2023 | ||
| * (PW-1697) Fixed validation pattern in fields 14[H,K,L,M,N,O] and 29J |
There was a problem hiding this comment.
Fix the indentation of the list item.
The list item should be indented correctly for better readability.
- * (PW-1697) Fixed validation pattern in fields 14[H,K,L,M,N,O] and 29J
+* (PW-1697) Fixed validation pattern in fields 14[H,K,L,M,N,O] and 29JCommittable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| * (PW-1697) Fixed validation pattern in fields 14[H,K,L,M,N,O] and 29J | |
| * (PW-1697) Fixed validation pattern in fields 14[H,K,L,M,N,O] and 29J |
Tools
Markdownlint
32-32: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
32-32: null
Lists should be surrounded by blank lines(MD032, blanks-around-lists)
| * (PW-1913) Added IBAN validation for Egypt local account structure | ||
| * Restore deprecated method in MT210 class |
There was a problem hiding this comment.
Fix the indentation of the list items.
The list items should be indented correctly for better readability.
- * (PW-1913) Added IBAN validation for Egypt local account structure
- * Restore deprecated method in MT210 class
+* (PW-1913) Added IBAN validation for Egypt local account structure
+* Restore deprecated method in MT210 classCommittable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| * (PW-1913) Added IBAN validation for Egypt local account structure | |
| * Restore deprecated method in MT210 class | |
| * (PW-1913) Added IBAN validation for Egypt local account structure | |
| * Restore deprecated method in MT210 class |
Tools
Markdownlint
4-4: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
5-5: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
4-4: null
Lists should be surrounded by blank lines(MD032, blanks-around-lists)
| * (PW-1675) update to Field 31R to support also two date components as requested by SCORE messages | ||
| * Added 36B and 36D getters to MT543 |
There was a problem hiding this comment.
Fix the indentation of the list items.
The list items should be indented correctly for better readability.
- * (PW-1675) update to Field 31R to support also two date components as requested by SCORE messages
- * Added 36B and 36D getters to MT543
+* (PW-1675) update to Field 31R to support also two date components as requested by SCORE messages
+* Added 36B and 36D getters to MT543Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| * (PW-1675) update to Field 31R to support also two date components as requested by SCORE messages | |
| * Added 36B and 36D getters to MT543 | |
| * (PW-1675) update to Field 31R to support also two date components as requested by SCORE messages | |
| * Added 36B and 36D getters to MT543 |
Tools
Markdownlint
39-39: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
40-40: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
39-39: null
Lists should be surrounded by blank lines(MD032, blanks-around-lists)
| * (PW-1862) Added NarrativeFragment class for detailed line information in StructuredNarrative fragments | ||
| * Fixed SwiftMessage getPDE(): return empty value instead of null when codeword exists and has no value | ||
| * Added isPercentage() helper method to field 37K |
There was a problem hiding this comment.
Fix the indentation of the list items.
The list items should be indented correctly for better readability.
- * (PW-1862) Added NarrativeFragment class for detailed line information in StructuredNarrative fragments
- * Fixed SwiftMessage getPDE(): return empty value instead of null when codeword exists and has no value
- * Added isPercentage() helper method to field 37K
+* (PW-1862) Added NarrativeFragment class for detailed line information in StructuredNarrative fragments
+* Fixed SwiftMessage getPDE(): return empty value instead of null when codeword exists and has no value
+* Added isPercentage() helper method to field 37KCommittable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| * (PW-1862) Added NarrativeFragment class for detailed line information in StructuredNarrative fragments | |
| * Fixed SwiftMessage getPDE(): return empty value instead of null when codeword exists and has no value | |
| * Added isPercentage() helper method to field 37K | |
| * (PW-1862) Added NarrativeFragment class for detailed line information in StructuredNarrative fragments | |
| * Fixed SwiftMessage getPDE(): return empty value instead of null when codeword exists and has no value | |
| * Added isPercentage() helper method to field 37K |
Tools
Markdownlint
14-14: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
15-15: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
16-16: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
14-14: null
Lists should be surrounded by blank lines(MD032, blanks-around-lists)
| * (PW-1812) Updated the narrative resolver, format 2 (used in field 72 for example), to allow empty values as part of the narrative fragment | ||
| * Updated validators for BIC, country, and currency constraints to utilize keywords for i18n-compatible messages | ||
| * Deprecated unnecessary methods in the SafeXmlUtils class |
There was a problem hiding this comment.
Fix the indentation of the list items.
The list items should be indented correctly for better readability.
- * (PW-1812) Updated the narrative resolver, format 2 (used in field 72 for example), to allow empty values as part of the narrative fragment
- * Updated validators for BIC, country, and currency constraints to utilize keywords for i18n-compatible messages
- * Deprecated unnecessary methods in the SafeXmlUtils class
+* (PW-1812) Updated the narrative resolver, format 2 (used in field 72 for example), to allow empty values as part of the narrative fragment
+* Updated validators for BIC, country, and currency constraints to utilize keywords for i18n-compatible messages
+* Deprecated unnecessary methods in the SafeXmlUtils classCommittable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| * (PW-1812) Updated the narrative resolver, format 2 (used in field 72 for example), to allow empty values as part of the narrative fragment | |
| * Updated validators for BIC, country, and currency constraints to utilize keywords for i18n-compatible messages | |
| * Deprecated unnecessary methods in the SafeXmlUtils class | |
| * (PW-1812) Updated the narrative resolver, format 2 (used in field 72 for example), to allow empty values as part of the narrative fragment | |
| * Updated validators for BIC, country, and currency constraints to utilize keywords for i18n-compatible messages | |
| * Deprecated unnecessary methods in the SafeXmlUtils class |
Tools
Markdownlint
19-19: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
20-20: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
21-21: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
19-19: null
Lists should be surrounded by blank lines(MD032, blanks-around-lists)
| * (PW-1695) Fixed a stack overflow in the fields fromJson implementation when a malformed JSON input contains empty field names | ||
| * (PW-1688) Added missing field labels for SRU2023 changes in the pw_swift_*.properties file |
There was a problem hiding this comment.
Fix the indentation of the list items.
The list items should be indented correctly for better readability.
- * (PW-1695) Fixed a stack overflow in the fields fromJson implementation when a malformed JSON input contains empty field names
- * (PW-1688) Added missing field labels for SRU2023 changes in the pw_swift_*.properties file
+* (PW-1695) Fixed a stack overflow in the fields fromJson implementation when a malformed JSON input contains empty field names
+* (PW-1688) Added missing field labels for SRU2023 changes in the pw_swift_*.properties fileCommittable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| * (PW-1695) Fixed a stack overflow in the fields fromJson implementation when a malformed JSON input contains empty field names | |
| * (PW-1688) Added missing field labels for SRU2023 changes in the pw_swift_*.properties file | |
| * (PW-1695) Fixed a stack overflow in the fields fromJson implementation when a malformed JSON input contains empty field names | |
| * (PW-1688) Added missing field labels for SRU2023 changes in the pw_swift_*.properties file |
Tools
Markdownlint
35-35: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
36-36: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
35-35: null
Lists should be surrounded by blank lines(MD032, blanks-around-lists)
| * SWIFT Standard release update 2024 (live 16 November 2025) | ||
| * Yearly revision of deprecation phase (see https://dev.prowidesoftware.com/SRU2024/getting-started/deprecation/) | ||
| * Dependency update: commons-lang3 -> 3.14.0' | ||
| * Dependency update: gson -> 2.11.0' | ||
| * Dependency update: commons-lang3 -> 3.14.0 | ||
| * Dependency update: gson -> 2.11.0 |
There was a problem hiding this comment.
Fix the indentation of the list items.
The list items should be indented correctly for better readability.
- * SWIFT Standard release update 2024 (live 16 November 2025)
- * Yearly revision of deprecation phase (see https://dev.prowidesoftware.com/SRU2024/getting-started/deprecation/)
- * Dependency update: commons-lang3 -> 3.14.0
- * Dependency update: gson -> 2.11.0
+* SWIFT Standard release update 2024 (live 16 November 2025)
+* Yearly revision of deprecation phase (see https://dev.prowidesoftware.com/SRU2024/getting-started/deprecation/)
+* Dependency update: commons-lang3 -> 3.14.0
+* Dependency update: gson -> 2.11.0Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| * SWIFT Standard release update 2024 (live 16 November 2025) | |
| * Yearly revision of deprecation phase (see https://dev.prowidesoftware.com/SRU2024/getting-started/deprecation/) | |
| * Dependency update: commons-lang3 -> 3.14.0' | |
| * Dependency update: gson -> 2.11.0' | |
| * Dependency update: commons-lang3 -> 3.14.0 | |
| * Dependency update: gson -> 2.11.0 | |
| * SWIFT Standard release update 2024 (live 16 November 2025) | |
| * Yearly revision of deprecation phase (see https://dev.prowidesoftware.com/SRU2024/getting-started/deprecation/) | |
| * Dependency update: commons-lang3 -> 3.14.0 | |
| * Dependency update: gson -> 2.11.0 |
Tools
Markdownlint
8-8: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
9-9: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
10-10: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
11-11: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
8-8: null
Lists should be surrounded by blank lines(MD032, blanks-around-lists)
9-9: null
Bare URL used(MD034, no-bare-urls)
| * (PW-1697) Fixed validation/parse pattern in field 29O | ||
| * (PW-1697) MT306 changes in field 30I | ||
| * Added DistinguishedName with Builder in order to encapsulate the BIC branch name logic |
There was a problem hiding this comment.
Fix the indentation of the list items.
The list items should be indented correctly for better readability.
- * (PW-1697) Fixed validation/parse pattern in field 29O
- * (PW-1697) MT306 changes in field 30I
- * Added DistinguishedName with Builder in order to encapsulate the BIC branch name logic
+* (PW-1697) Fixed validation/parse pattern in field 29O
+* (PW-1697) MT306 changes in field 30I
+* Added DistinguishedName with Builder in order to encapsulate the BIC branch name logic Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| * (PW-1697) Fixed validation/parse pattern in field 29O | |
| * (PW-1697) MT306 changes in field 30I | |
| * Added DistinguishedName with Builder in order to encapsulate the BIC branch name logic | |
| * (PW-1697) Fixed validation/parse pattern in field 29O | |
| * (PW-1697) MT306 changes in field 30I | |
| * Added DistinguishedName with Builder in order to encapsulate the BIC branch name logic |
Tools
LanguageTool
[style] ~29-~29: Consider a shorter alternative to avoid wordiness.
Context: ... * Added DistinguishedName with Builder in order to encapsulate the BIC branch name logic ...(IN_ORDER_TO_PREMIUM)
Markdownlint
27-27: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
28-28: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
29-29: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
29-29: Expected: 0 or 2; Actual: 1
Trailing spaces(MD009, no-trailing-spaces)
27-27: null
Lists should be surrounded by blank lines(MD032, blanks-around-lists)
Summary by CodeRabbit
New Features
NarrativeFragmentclass for detailed line information.isPercentage()helper method to field37K.Bug Fixes
SwiftMessage getPDE()method to return empty value instead of null.29O.fromJsonimplementation.14[H,K,L,M,N,O]and29J.Updates
commons-lang3to version3.14.0,gsonto version2.11.0.Deprecations
SafeXmlUtilsclass.NameandAddressforNarrativeinField 24G.