-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CU-85zrnb6u1_PW---631--XML-Handling #75
base: develop
Are you sure you want to change the base?
Conversation
Task linked: CU-85zrnb6u1 PW - 631 ⁃ XML Handling |
@zubri fijate que te deje unos comments para confirmar sobre |
**Por lo que vi, a las clases Mx de dominio, deberíamos agregarle un metodo extra. Ejemplifico con MxPacs00800108: Existente:**
Nuevo:
|
if (usableConf.includeXMLDeclaration) { | ||
xml.append("<?xml version=\"1.0\" encoding=\"UTF-8\" ?>\n"); | ||
Charset charsetToUse =conf.charset != null? conf.charset:Charset.defaultCharset(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Esta ok esto... y estaría bueno probar generar un XML pasando un encoding diferente en Java y ver que genera.
Este cambio debiera romper unos cuantos test en tu maquina que creo que al ser Windows como default charset tiene algo distinto.
iso20022-core/src/main/java/com/prowidesoftware/swift/model/mx/MxParseUtils.java
Outdated
Show resolved
Hide resolved
iso20022-core/src/main/java/com/prowidesoftware/swift/model/mx/MxRead.java
Outdated
Show resolved
Hide resolved
iso20022-core/src/main/java/com/prowidesoftware/swift/model/mx/MxReadConfiguration.java
Outdated
Show resolved
Hide resolved
iso20022-core/src/main/java/com/prowidesoftware/swift/model/mx/MxReadParams.java
Outdated
Show resolved
Hide resolved
iso20022-core/src/main/java/com/prowidesoftware/swift/model/mx/MxWriteConfiguration.java
Outdated
Show resolved
Hide resolved
iso20022-core/src/main/java/com/prowidesoftware/swift/model/mx/MxWriteParams.java
Outdated
Show resolved
Hide resolved
iso20022-core/src/main/java/com/prowidesoftware/swift/model/mx/MxRead.java
Outdated
Show resolved
Hide resolved
24dfcb1
to
eb43849
Compare
No description provided.