PW-1462: Parse refactor to support Any inner content in xsys messages #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zubri
requested changes
Aug 22, 2023
| return Optional.ofNullable(parsedDocument); | ||
| } | ||
|
|
||
| private static String getDocumentXml(String xml, MxReadParams params) { |
There was a problem hiding this comment.
Este metodo no se usa por lo que veo. Es el intento por lo de Any? En general hay que evitar usar DOM, es muy lento, por eso usamos Sax
There was a problem hiding this comment.
La llamada a este método está comentada. Habíamos quedado en que lo subía así y vos revisabas si no encontrabas una solución mejor. Este branch fue una 1era idea que no te convencía.
iso20022-core/src/test/resources/sample_hvcs_xsys.002_pacs.008_namespaces.xml
Show resolved
Hide resolved
zubri
changed the title
ptorres-prowide
force-pushed
the
CU-85ztm247h_PW-1462--PMH-Bottomline-GTX-extension-test-case-fails-to-parse-xsys002
branch
from
b90d8f8
to
6c7b659
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…-parse-xsys002