chore: change check name

prowler-cloud · Sep 12, 2024 · d7dbd94 · d7dbd94
1 parent 4b5487f
commit d7dbd94
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 23 deletions.
diff --git a/...stom_origin_traffic_encrypted/__init__.py → ...ions_origin_traffic_encrypted/__init__.py b/...stom_origin_traffic_encrypted/__init__.py → ...ions_origin_traffic_encrypted/__init__.py
diff --git a/...om_origin_traffic_encrypted.metadata.json → ...ns_origin_traffic_encrypted.metadata.json b/...om_origin_traffic_encrypted.metadata.json → ...ns_origin_traffic_encrypted.metadata.json
@@ -1,10 +1,8 @@
 {
   "Provider": "aws",
-  "CheckID": "cloudfront_distributions_custom_origin_traffic_encrypted",
+  "CheckID": "cloudfront_distributions_origin_traffic_encrypted",
   "CheckTitle": "Check if CloudFront distributions encrypt traffic to custom origins.",
-  "CheckType": [
-    "NIST 800-53 Controls"
-  ],
+  "CheckType": [],
   "ServiceName": "cloudfront",
   "SubServiceName": "",
   "ResourceIdTemplate": "arn:partition:cloudfront:region:account-id:distribution/resource-id",

diff --git a/...utions_custom_origin_traffic_encrypted.py → ...distributions_origin_traffic_encrypted.py b/...utions_custom_origin_traffic_encrypted.py → ...distributions_origin_traffic_encrypted.py
@@ -4,7 +4,7 @@
 )
 
 
-class cloudfront_distributions_custom_origin_traffic_encrypted(Check):
+class cloudfront_distributions_origin_traffic_encrypted(Check):
     def execute(self):
         findings = []
         for distribution in cloudfront_client.distributions.values():
@@ -14,7 +14,7 @@ def execute(self):
             report.resource_id = distribution.id
             report.resource_tags = distribution.tags
             report.status = "PASS"
-            report.status_extended = f"CloudFront Distribution {distribution.id} does encrypt traﬃc to custom origins."
+            report.status_extended = f"CloudFront Distribution {distribution.id} does encrypt traffic to custom origins."
 
             for origin in distribution.origins:
                 if (
@@ -25,7 +25,7 @@ def execute(self):
                     and distribution.viewer_protocol_policy == "allow-all"
                 ):
                     report.status = "FAIL"
-                    report.status_extended = f"CloudFront Distribution {distribution.id} does not encrypt traﬃc to custom origins."
+                    report.status_extended = f"CloudFront Distribution {distribution.id} does not encrypt traffic to custom origins."
 
             findings.append(report)
 

diff --git a/...s_custom_origin_traffic_encrypted_test.py → ...ibutions_origin_traffic_encrypted_test.py b/...s_custom_origin_traffic_encrypted_test.py → ...ibutions_origin_traffic_encrypted_test.py
@@ -15,7 +15,7 @@
 REGION = "eu-west-1"
 
 
-class Test_cloudfront_distributions_custom_origin_traffic_encrypted:
+class Test_cloudfront_distributions_origin_traffic_encrypted:
     def test_no_distributions(self):
         cloudfront_client = mock.MagicMock
         cloudfront_client.distributions = {}
@@ -24,11 +24,11 @@ def test_no_distributions(self):
             new=cloudfront_client,
         ):
             # Test Check
-            from prowler.providers.aws.services.cloudfront.cloudfront_distributions_custom_origin_traffic_encrypted.cloudfront_distributions_custom_origin_traffic_encrypted import (
-                cloudfront_distributions_custom_origin_traffic_encrypted,
+            from prowler.providers.aws.services.cloudfront.cloudfront_distributions_origin_traffic_encrypted.cloudfront_distributions_origin_traffic_encrypted import (
+                cloudfront_distributions_origin_traffic_encrypted,
             )
 
-            check = cloudfront_distributions_custom_origin_traffic_encrypted()
+            check = cloudfront_distributions_origin_traffic_encrypted()
             result = check.execute()
 
             assert len(result) == 0
@@ -63,11 +63,11 @@ def test_distribution_no_traffic_encryption(self):
             new=cloudfront_client,
         ):
             # Test Check
-            from prowler.providers.aws.services.cloudfront.cloudfront_distributions_custom_origin_traffic_encrypted.cloudfront_distributions_custom_origin_traffic_encrypted import (
-                cloudfront_distributions_custom_origin_traffic_encrypted,
+            from prowler.providers.aws.services.cloudfront.cloudfront_distributions_origin_traffic_encrypted.cloudfront_distributions_origin_traffic_encrypted import (
+                cloudfront_distributions_origin_traffic_encrypted,
             )
 
-            check = cloudfront_distributions_custom_origin_traffic_encrypted()
+            check = cloudfront_distributions_origin_traffic_encrypted()
             result = check.execute()
 
             assert len(result) == 1
@@ -110,11 +110,11 @@ def test_distribution_http_only(self):
             new=cloudfront_client,
         ):
             # Test Check
-            from prowler.providers.aws.services.cloudfront.cloudfront_distributions_custom_origin_traffic_encrypted.cloudfront_distributions_custom_origin_traffic_encrypted import (
-                cloudfront_distributions_custom_origin_traffic_encrypted,
+            from prowler.providers.aws.services.cloudfront.cloudfront_distributions_origin_traffic_encrypted.cloudfront_distributions_origin_traffic_encrypted import (
+                cloudfront_distributions_origin_traffic_encrypted,
             )
 
-            check = cloudfront_distributions_custom_origin_traffic_encrypted()
+            check = cloudfront_distributions_origin_traffic_encrypted()
             result = check.execute()
 
             assert len(result) == 1
@@ -158,11 +158,11 @@ def test_distribution_match_viewer_allow_all(self):
             new=cloudfront_client,
         ):
             # Test Check
-            from prowler.providers.aws.services.cloudfront.cloudfront_distributions_custom_origin_traffic_encrypted.cloudfront_distributions_custom_origin_traffic_encrypted import (
-                cloudfront_distributions_custom_origin_traffic_encrypted,
+            from prowler.providers.aws.services.cloudfront.cloudfront_distributions_origin_traffic_encrypted.cloudfront_distributions_origin_traffic_encrypted import (
+                cloudfront_distributions_origin_traffic_encrypted,
             )
 
-            check = cloudfront_distributions_custom_origin_traffic_encrypted()
+            check = cloudfront_distributions_origin_traffic_encrypted()
             result = check.execute()
 
             assert len(result) == 1
@@ -205,11 +205,11 @@ def test_distribution_traffic_encrypted(self):
             new=cloudfront_client,
         ):
             # Test Check
-            from prowler.providers.aws.services.cloudfront.cloudfront_distributions_custom_origin_traffic_encrypted.cloudfront_distributions_custom_origin_traffic_encrypted import (
-                cloudfront_distributions_custom_origin_traffic_encrypted,
+            from prowler.providers.aws.services.cloudfront.cloudfront_distributions_origin_traffic_encrypted.cloudfront_distributions_origin_traffic_encrypted import (
+                cloudfront_distributions_origin_traffic_encrypted,
             )
 
-            check = cloudfront_distributions_custom_origin_traffic_encrypted()
+            check = cloudfront_distributions_origin_traffic_encrypted()
             result = check.execute()
 
             assert len(result) == 1