Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(version): update version logic in Prowler #4654

Merged

Conversation

MrCloudSec
Copy link
Member

@MrCloudSec MrCloudSec commented Aug 6, 2024

Description

Removing in GitHub actions the bumping version logic since we are going to do a PR changing the version before releasing.

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@MrCloudSec MrCloudSec requested review from a team as code owners August 6, 2024 18:03
@github-actions github-actions bot added the github_actions Pull requests that update GitHub Actions code label Aug 6, 2024
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.08%. Comparing base (f746a9e) to head (9a3d12d).
Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4654   +/-   ##
=======================================
  Coverage   89.08%   89.08%           
=======================================
  Files         910      910           
  Lines       27737    27739    +2     
=======================================
+ Hits        24709    24711    +2     
  Misses       3028     3028           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jfagoagas jfagoagas added the no-merge Please, DO NOT MERGE this PR. label Aug 7, 2024
Copy link
Member

@jfagoagas jfagoagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep just the version change. The changes in the actions will require further testing.

@jfagoagas jfagoagas removed the no-merge Please, DO NOT MERGE this PR. label Aug 7, 2024
@jfagoagas jfagoagas self-requested a review August 7, 2024 12:15
@jfagoagas
Copy link
Member

Please update the PR title.

Copy link
Member

@jfagoagas jfagoagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@jfagoagas jfagoagas merged commit 28bed98 into master Aug 7, 2024
9 checks passed
@jfagoagas jfagoagas deleted the PRWLR-4415-update-master-branch-version-in-prowler branch August 7, 2024 16:15
github-actions bot pushed a commit that referenced this pull request Aug 7, 2024
@github-actions github-actions bot added the was-backported The PR was successfully backported to the target branch label Aug 7, 2024
Copy link
Contributor

github-actions bot commented Aug 7, 2024

💚 All backports created successfully

Status Branch Result
v4.3

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@MrCloudSec MrCloudSec added the backport-to-v3 Backport PR to the v3 branch label Aug 16, 2024
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
v3

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

MrCloudSec added a commit that referenced this pull request Aug 16, 2024
@jfagoagas jfagoagas added the backport-to-v4.3 Backport PR to the v4.3 branch label Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-v3 Backport PR to the v3 branch backport-to-v4.3 Backport PR to the v4.3 branch github_actions Pull requests that update GitHub Actions code was-backported The PR was successfully backported to the target branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants