Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ecr): handle non-existing findingSeverityCounts key #4746

Merged

Conversation

MrCloudSec
Copy link
Member

Description

Handle non-existing findingSeverityCounts key when an image has no findings and getting the following error:

KeyError[207]: 'findingSeverityCounts'

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@MrCloudSec MrCloudSec requested review from a team as code owners August 14, 2024 20:03
@github-actions github-actions bot added the provider/aws Issues/PRs related with the AWS provider label Aug 14, 2024
@MrCloudSec MrCloudSec added backport-to-v3 Backport PR to the v3 branch backport-to-v4.3 labels Aug 14, 2024
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.09%. Comparing base (ae1b114) to head (ecc60bd).
Report is 568 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4746   +/-   ##
=======================================
  Coverage   89.09%   89.09%           
=======================================
  Files         920      920           
  Lines       28125    28125           
=======================================
+ Hits        25057    25058    +1     
+ Misses       3068     3067    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@drewkerrigan drewkerrigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Member

@puchy22 puchy22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch 💯

@MrCloudSec MrCloudSec merged commit 98fc624 into master Aug 16, 2024
13 checks passed
@MrCloudSec MrCloudSec deleted the PRWLR-4587-solve-key-error-207-finding-severity-counts branch August 16, 2024 15:42
@github-actions github-actions bot added the was-backported The PR was successfully backported to the target branch label Aug 16, 2024
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
v3
v4.3

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

MrCloudSec added a commit that referenced this pull request Aug 16, 2024
MrCloudSec added a commit that referenced this pull request Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-v3 Backport PR to the v3 branch provider/aws Issues/PRs related with the AWS provider was-backported The PR was successfully backported to the target branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants