-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ecr): handle non-existing findingSeverityCounts key #4746
fix(ecr): handle non-existing findingSeverityCounts key #4746
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4746 +/- ##
=======================================
Coverage 89.09% 89.09%
=======================================
Files 920 920
Lines 28125 28125
=======================================
+ Hits 25057 25058 +1
+ Misses 3068 3067 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch 💯
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
(cherry picked from commit 98fc624)
(cherry picked from commit 98fc624)
Description
Handle non-existing
findingSeverityCounts
key when an image has no findings and getting the following error:KeyError[207]: 'findingSeverityCounts'
Checklist
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.