docs(is_item_matched): update docstrings for method #4836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfagoagas
requested changes
Aug 22, 2024
prowler/lib/mutelist/mutelist.py
Outdated
| @@ -314,6 +314,7 @@ def is_item_matched(matched_items, finding_items, tag=False) -> bool: | |||
| Args: | |||
| matched_items (list): List of items to be matched. | |||
| finding_items (str): String to search for matched items. | |||
| tag (bool): If True the search will have a different logic due to the tags being ORed or ANDed. | |||
There was a problem hiding this comment.
Please give this some care and explain the new logic perform while checking for muted tags. Thanks!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4836 +/- ##
==========================================
+ Coverage 89.11% 89.16% +0.04%
==========================================
Files 928 933 +5
Lines 28428 28567 +139
==========================================
+ Hits 25335 25473 +138
- Misses 3093 3094 +1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
jfagoagas
reviewed
Aug 23, 2024
jfagoagas
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update docstrings for
is_item_matchedChecklist
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.