Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aws): handle AWS key-only tags #4845

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Conversation

MrCloudSec
Copy link
Member

Description

Handle AWS Tags that only have keys and non-existing values so no KeyError can raise.

>>> tags = [{"Key": "name"}]
>>> unroll_tags(tags)
{'name': ''}

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@MrCloudSec MrCloudSec requested review from a team as code owners August 22, 2024 20:35
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.16%. Comparing base (c2552ee) to head (a0bc742).
Report is 558 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4845   +/-   ##
=======================================
  Coverage   89.16%   89.16%           
=======================================
  Files         933      933           
  Lines       28567    28567           
=======================================
  Hits        25473    25473           
  Misses       3094     3094           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Member

@jfagoagas jfagoagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several questions:

  • What is the origin of this issue?
  • Does it need to be backported to v4.3 and v3?

Copy link
Member

@jfagoagas jfagoagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!

@jfagoagas jfagoagas merged commit fb449ce into master Aug 23, 2024
12 checks passed
@jfagoagas jfagoagas deleted the fix-tags-with-key-only branch August 23, 2024 11:03
github-actions bot pushed a commit that referenced this pull request Aug 23, 2024
@github-actions github-actions bot added the was-backported The PR was successfully backported to the target branch label Aug 23, 2024
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
v4.3

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
was-backported The PR was successfully backported to the target branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants