Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aws): Add new check to ensure RDS db clusters copy tags to snapshots #4846

Conversation

danibarranqueroo
Copy link
Member

Context

This new check ensures that Amazon RDS DB clusters are configured to automatically copy all tags to their snapshots upon creation. Tagging snapshots consistently with their parent DB clusters improves asset identification and inventory management, facilitating effective governance and security oversight.

Description

Added rds_cluster_copy_tags_to_snapshots check with its unit test.

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@danibarranqueroo danibarranqueroo requested review from a team as code owners August 23, 2024 07:16
@github-actions github-actions bot added the provider/aws Issues/PRs related with the AWS provider label Aug 23, 2024
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.16%. Comparing base (c2552ee) to head (1153069).
Report is 559 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4846      +/-   ##
==========================================
- Coverage   89.16%   89.16%   -0.01%     
==========================================
  Files         933      934       +1     
  Lines       28567    28585      +18     
==========================================
+ Hits        25473    25488      +15     
- Misses       3094     3097       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Member

@MrCloudSec MrCloudSec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@MrCloudSec MrCloudSec merged commit 472aea6 into prowler-cloud:master Aug 23, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/aws Issues/PRs related with the AWS provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants