feat(ec2): Ensure EC2 launch templates do not assign public IPs #4852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… chose what we save for each launch template version, adjust the service test to the changes
MrCloudSec
reviewed
Aug 23, 2024
Comment on lines
24
to
25
| f"EC2 Launch Template {template.name} in template versions: " | ||
| f"{', '.join(versions_with_public_ip)} is configured to assign a public IP address." |
There was a problem hiding this comment.
Suggested change
| f"EC2 Launch Template {template.name} in template versions: " | |
| f"{', '.join(versions_with_public_ip)} is configured to assign a public IP address." | |
| f"EC2 Launch Template {template.name} is configured to assign a public IP address to network interfaces upon launch in template versions: f"{', '.join(versions_with_public_ip)}." |
MrCloudSec
reviewed
Aug 23, 2024
| ) | ||
| else: | ||
| report.status = "PASS" | ||
| report.status_extended = f"No versions of EC2 Launch Template {template.name} are configured to assign a public IP address." |
There was a problem hiding this comment.
Suggested change
| report.status_extended = f"No versions of EC2 Launch Template {template.name} are configured to assign a public IP address." | |
| report.status_extended = f"EC2 Launch Template {template.name} is not configured to assign a public IP address to network interfaces upon launch." |
|
Can we also check the second part of the check? |
…-in-template-data-in-launch-template-version' into PRWLR-4304-add-new-ec-2-check-to-ensure-public-i-ps-are-not-assigned-to-network-interfaces
…bute public_ip_addresses with ipaddress IPs to the NetworkInterface model with tests, added tags to LaunchTemplate model and list with network interfaces to TemplateData model
…erfaces to adjust to the change from list to dict and add new attribute public_ip_addresses to one ec2 test
…-in-template-data-in-launch-template-version' into PRWLR-4304-add-new-ec-2-check-to-ensure-public-i-ps-are-not-assigned-to-network-interfaces
…he-data-saved-in-template-data-in-launch-template-version
…-in-template-data-in-launch-template-version' into PRWLR-4304-add-new-ec-2-check-to-ensure-public-i-ps-are-not-assigned-to-network-interfaces
…blic_ip_addresses
…-in-template-data-in-launch-template-version' into PRWLR-4304-add-new-ec-2-check-to-ensure-public-i-ps-are-not-assigned-to-network-interfaces
…check, change the default value for the publi_ip_autoassign and add tests
Base automatically changed from
PRWLR-4617-change-ec-2-service-to-adjust-the-data-saved-in-template-data-in-launch-template-version
to
master
September 9, 2024 16:32
…blic-i-ps-are-not-assigned-to-network-interfaces
github-actions
bot
added
the
provider/aws
MrCloudSec
reviewed
Sep 10, 2024
| versions_with_network_interfaces_public_ip.append( | ||
| str(version.version_number) | ||
| ) | ||
| break |
There was a problem hiding this comment.
Why a break here? Don't we want to add all the versions with this issue?
There was a problem hiding this comment.
That break is only to stop looking in the network interfaces for public IPs, it will still add every version that is using a network interface with a public IP. That is only to optimize because a version can have a ton of network interfaces and it could take so long if not adding that break. My first idea was to add the network interface's id but that would require to iterate over all the network interfaces and that could cause the check to take a lot of time.
MrCloudSec
reviewed
Sep 10, 2024
| ) | ||
| if version.template_data.network_interfaces: | ||
| for network_interface in version.template_data.network_interfaces: | ||
| if network_interface.public_ip_addresses != []: |
There was a problem hiding this comment.
Suggested change
| if network_interface.public_ip_addresses != []: | |
| if network_interface.public_ip_addresses: |
MrCloudSec
reviewed
Sep 10, 2024
Comment on lines
31
to
48
| if ( | ||
| versions_with_autoassign_public_ip | ||
| or versions_with_network_interfaces_public_ip | ||
| ): | ||
| report.status = "FAIL" | ||
| extended_messages = [] | ||
|
|
||
| if versions_with_autoassign_public_ip: | ||
| extended_messages.append( | ||
| f"EC2 Launch Template {template.name} is configured to assign a public IP address to network interfaces upon launch in template versions: {', '.join(versions_with_autoassign_public_ip)}." | ||
| ) | ||
|
|
||
| if versions_with_network_interfaces_public_ip: | ||
| extended_messages.append( | ||
| f"EC2 Launch Template {template.name} is using a network interface with public IP addresses in template versions: {', '.join(versions_with_network_interfaces_public_ip)}." | ||
| ) | ||
|
|
||
| report.status_extended = " ".join(extended_messages) |
There was a problem hiding this comment.
It is better to create 3 different status extended that using this logic to mix two of them.
MrCloudSec
changed the title
…blic-i-ps-are-not-assigned-to-network-interfaces
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4852 +/- ##
==========================================
+ Coverage 88.92% 88.97% +0.05%
==========================================
Files 945 958 +13
Lines 29026 29372 +346
==========================================
+ Hits 25810 26134 +324
- Misses 3216 3238 +22
|
MrCloudSec
approved these changes
Sep 16, 2024
MrCloudSec
deleted the
PRWLR-4304-add-new-ec-2-check-to-ensure-public-i-ps-are-not-assigned-to-network-interfaces
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This check verifies whether Amazon EC2 launch templates are configured to assign public IP addresses to network interfaces upon launch. The check fails if an EC2 launch template is set to assign a public IP address to network interfaces or if any network interface has a public IP address.
Description
Added
ec2_launch_template_no_public_ipcheck with metadata and respective unit tests.Checklist
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.