feat(cloudfront): Add new cloudfront_distributions_s3_origin_access_control check to ensure OAC is configured in distributions
#4939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
provider/aws
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4939 +/- ##
==========================================
+ Coverage 88.92% 88.97% +0.04%
==========================================
Files 953 957 +4
Lines 29237 29340 +103
==========================================
+ Hits 25999 26105 +106
+ Misses 3238 3235 -3
|
MrCloudSec
reviewed
Sep 9, 2024
| @@ -0,0 +1,32 @@ | |||
| { | |||
| "Provider": "aws", | |||
| "CheckID": "cloudfront_distributions_use_origin_access_control", | |||
There was a problem hiding this comment.
Suggested change
| "CheckID": "cloudfront_distributions_use_origin_access_control", | |
| "CheckID": "cloudfront_distributions_s3_origin_access_control", |
MrCloudSec
reviewed
Sep 9, 2024
There was a problem hiding this comment.
Why you did not use moto here?
MrCloudSec
reviewed
Sep 10, 2024
| { | ||
| "Provider": "aws", | ||
| "CheckID": "cloudfront_distributions_use_origin_access_control", | ||
| "CheckTitle": "Check if CloudFront distributions use OAC.", |
There was a problem hiding this comment.
Suggested change
| "CheckTitle": "Check if CloudFront distributions use OAC.", | |
| "CheckTitle": "Check if CloudFront distributions with S3 origin use OAC.", |
Please, update the metadata adding that is only for CloudFront distributions with S3 origins.
MrCloudSec
reviewed
Sep 10, 2024
There was a problem hiding this comment.
Please, only check for CloudFront distributions with S3 origins.
There was a problem hiding this comment.
And iterate for the origins in each distribution
MrCloudSec
reviewed
Sep 10, 2024
| @@ -49,6 +49,14 @@ def _get_distribution_config(self, client, distributions, region) -> dict: | |||
| try: | |||
| for distribution_id in distributions.keys(): | |||
| distribution_config = client.get_distribution_config(Id=distribution_id) | |||
| oac = False | |||
There was a problem hiding this comment.
This is not needed, since we already have the origins for each distribution.
There was a problem hiding this comment.
Use the Origin class please.
…o PRWLR-4451-ensure-cloud-front-distributions-use-origin-access-control-oac pull changes from master
…s-use-origin-access-control-oac
…s-use-origin-access-control-oac
MrCloudSec
approved these changes
Sep 13, 2024
MrCloudSec
changed the title
cloudfront_distributions_use_origin_access_control check to ensure OAC is configured in distributionscloudfront_distributions_s3_origin_access_control check to ensure OAC is configured in distributions
MrCloudSec
deleted the
PRWLR-4451-ensure-cloud-front-distributions-use-origin-access-control-oac
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Without OAC, users might be able to access S3 content directly, bypassing CloudFront, which can expose sensitive data. OAC limits access to the S3 bucket exclusively through the CloudFront distribution, preventing direct access and offering better security controls compared to the older Origin Access Identity (OAI). This helps reduce the risk of unauthorized access to the S3 origin.
Description
The
cloudfront_distributions_s3_origin_access_controlcheck verifies whether OAC is enabled for CloudFront distributions with S3 origins. If OAC is not configured, the check fails, leaving the S3 content potentially vulnerable to direct access. This check ensures that access to the S3 bucket is properly restricted, allowing only traffic routed through the associated CloudFront distribution, enhancing security by enforcing best practices.Checklist
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.