Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(repository): add new check repository_merging_requires_conversation_resolution #6208

Open
wants to merge 4 commits into
base: PRWLR-5536-ensure-branch-protection-rules-are-enforced-for-administrators
Choose a base branch
from

Conversation

HugoPBrito
Copy link
Member

Context

Code changes often come with reviewer feedback, which can include suggestions for improvements, bug fixes, or security concerns. Unaddressed open comments could result in unreviewed issues being merged into the codebase, potentially introducing errors or vulnerabilities. Ensuring that all comments are resolved before merging code enforces accountability and ensures that concerns are addressed in a timely manner.

Description

This check ensures that all open comments are resolved before allowing a code change to be merged. By enforcing this rule, organizations make sure that all issues raised by reviewers, whether they are related to bugs, security, or code quality, are properly acknowledged and acted upon. This policy helps maintain the integrity and quality of the codebase.

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@HugoPBrito HugoPBrito requested review from a team as code owners December 16, 2024 13:20
…for-administrators' into PRWLR-5534-ensure-all-open-comments-are-resolved-before-allowing-code-change-merging
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant