Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(config): set default values for empty config fields #6225

Merged

Conversation

pedrooot
Copy link
Member

Context

Related with #5710

Description

This PR set the correct values for the config when it's used on the checks and the field is missing on the config.yaml file.

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@pedrooot pedrooot requested review from a team as code owners December 17, 2024 11:32
@github-actions github-actions bot added provider/aws Issues/PRs related with the AWS provider provider/kubernetes Issues/PRs related with the Kubernetes provider labels Dec 17, 2024
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.11%. Comparing base (0ec3ed8) to head (2f150ae).
Report is 12 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6225      +/-   ##
==========================================
- Coverage   93.37%   90.11%   -3.26%     
==========================================
  Files          63     1181    +1118     
  Lines        6021    36280   +30259     
==========================================
+ Hits         5622    32695   +27073     
- Misses        399     3585    +3186     
Flag Coverage Δ
api ?
prowler 90.11% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
prowler 90.11% <100.00%> (∅)
api ∅ <ø> (∅)

Copy link
Member

@MrCloudSec MrCloudSec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @pedrooot! Can you please change original_* to default_*, please?

@MrCloudSec MrCloudSec changed the title feat(config): set default values for empty config fields chore(config): set default values for empty config fields Dec 18, 2024
@MrCloudSec MrCloudSec merged commit 8f32299 into master Dec 18, 2024
10 of 11 checks passed
@MrCloudSec MrCloudSec deleted the PRWLR-5803-review-configs-default-values-where-used branch December 18, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/aws Issues/PRs related with the AWS provider provider/kubernetes Issues/PRs related with the Kubernetes provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants