Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aws): add new check cloudformation_stack_cdktoolkit_bootstrap_version #6323

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MrCloudSec
Copy link
Member

Context

This PR introduces a new check cloudformation_stack_cdktoolkit_bootstrap_version to validate the BootstrapVersion of CDKToolkit CloudFormation stacks. Ensuring the version is at least 21 helps mitigate risks like bucket takeover or privilege escalation, thanks @jchrisfarris for the idea!

Description

  • The check identifies CDKToolkit stacks and validates their BootstrapVersion output.
  • Flags stacks as FAIL if the version is below 21 or missing.
  • Includes unit tests covering valid, invalid, and missing BootstrapVersion scenarios.

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@MrCloudSec MrCloudSec requested review from a team as code owners December 26, 2024 23:53
@github-actions github-actions bot added the provider/aws Issues/PRs related with the AWS provider label Dec 26, 2024
Copy link

codecov bot commented Dec 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.09%. Comparing base (db5481c) to head (c45f24c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6323      +/-   ##
==========================================
- Coverage   90.12%   90.09%   -0.04%     
==========================================
  Files        1182     1183       +1     
  Lines       36315    36342      +27     
==========================================
+ Hits        32728    32741      +13     
- Misses       3587     3601      +14     
Flag Coverage Δ
prowler 90.09% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
prowler 90.09% <100.00%> (-0.04%) ⬇️
api ∅ <ø> (∅)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/aws Issues/PRs related with the AWS provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant