perf improvement for account + comments fixed in e2e multisig test

proximax-storage · Nov 19, 2019 · ef92335 · ef92335
1 parent 2e84280
commit ef92335
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/src/e2e/java/io/proximax/sdk/E2EMultisigTest.java b/src/e2e/java/io/proximax/sdk/E2EMultisigTest.java
@@ -145,7 +145,7 @@ void test01TransferFromMultisig1Of2AggregateBonded() {
       logger.info("request to transfer aggregate bonded confirmed: {}",
             listener.confirmed(cosig1.getAddress()).timeout(getTimeoutSeconds(), TimeUnit.SECONDS).blockingFirst());
       sleepForAWhile();
-      // announce the multisig change as aggregate bounded
+      // announce the multisig change as aggregate bonded
       logger.info("Announced the aggregate bonded transfer from multisig: {}",
             transactionHttp.announceAggregateBonded(signedTransaction).blockingFirst());
       logger.info("request to make transfer confirmed: {}",
@@ -213,7 +213,7 @@ void test02TransferFromMultisig2Of2AggregateBonded() {
       logger.info("request confirmed: {}",
             listener.confirmed(cosig1.getAddress()).timeout(getTimeoutSeconds(), TimeUnit.SECONDS).blockingFirst());
       sleepForAWhile();
-      // announce the multisig change as aggregate bounded
+      // announce the multisig change as aggregate bonded
       logger.info("Announced the transfer from multisig: {}",
             transactionHttp.announceAggregateBonded(signedTransaction).blockingFirst());
       logger.info("request confirmed: {}",
@@ -243,7 +243,7 @@ void test02TransferFromMultisig2Of2AggregateBondedSeparateConfirmation() {
       logger.info("request confirmed: {}",
             listener.confirmed(cosig1.getAddress()).timeout(getTimeoutSeconds(), TimeUnit.SECONDS).blockingFirst());
       sleepForAWhile();
-      // announce the multisig change as aggregate bounded
+      // announce the multisig change as aggregate bonded
       logger.info("Announced the transfer from multisig: {}",
             transactionHttp.announceAggregateBonded(signedTransaction).blockingFirst());
       logger.info("request confirmed: {}",
@@ -276,7 +276,7 @@ void test03AddCosignatory() throws InterruptedException, ExecutionException {
       logger.info("request confirmed: {}",
             listener.confirmed(cosig1.getAddress()).timeout(getTimeoutSeconds(), TimeUnit.SECONDS).blockingFirst());
       sleepForAWhile();
-      // announce the multisig change as aggregate bounded
+      // announce the multisig change as aggregate bonded
       logger.info("Announced the multisig change: {}",
             transactionHttp.announceAggregateBonded(signedTransaction).toFuture().get());
       logger.info("request confirmed: {}",

diff --git a/src/main/java/io/proximax/sdk/model/account/Account.java b/src/main/java/io/proximax/sdk/model/account/Account.java
@@ -76,8 +76,7 @@ public static Account createFromPrivateKey(String privateKey, NetworkType networ
     * @return new random account for specified network type
     */
    public static Account generateNewAccount(NetworkType networkType) {
-      KeyPair keyPair = new KeyPair();
-      return new Account(keyPair.getPrivateKey().toString(), networkType);
+      return new Account(new KeyPair(), networkType);
    }
 
    /**