Bump v8 to version 11.0.226.13 #328
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates to v8 to version 11.0.226.13 Note, the BTEC is unchanged so is not updated in repositories.bzl
|
@jlb6740 is there any reason this is still marked as a draft? What's missing? Also, could you merge with |
|
Hi @PiotrSikora Sorry I see I missed this ping. I need to revisit this and can do it later this week. At the time I didn't understand all the moving parts to the build system .. and I wasn't quite sure this was done correctly and I didn't get back to it. I think there needed to be an update to the v8.patch file and there might have been question about how to reconcile there being a version of v8 to update both here and in the envoy build. |
|
@jlb6740 any update? |
|
Superseded by #369. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to v8 to version 11.0.226.13
Note, the BTEC is unchanged so is not updated in repositories.bzl
Note this is a follow up for this draft PR #327
Had to rename branch since we are pushing a different version of v8 here compared to the previous iteration.
This is not quite ready as would like to understand the nature of callee-saved register bug mentioned here http://crrev.com/c/4171639 before updating to this version of v8.