Add implementation for new ABI proxy_log_destination #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vikaschoudhary16
requested review from
PiotrSikora and
mathetake
as code owners
Signed-off-by: Vikas Choudhary <[email protected]>
vikaschoudhary16
force-pushed
the
log-destination
branch
from
c002720 to
4c28647
Compare
PiotrSikora
reviewed
May 4, 2023
src/exports.cc
Outdated
| if (e.first == dest.value()) { | ||
| // write message to the file which is the value of the key if it exists | ||
| std::ofstream log_file; | ||
| log_file.open(e.second, std::ios::out | std::ios_base::app); |
There was a problem hiding this comment.
IMHO, this should be done on the proxy-side, so that it can use optimized logging facilities (if they exist), work with sandboxing, etc.
Basically, this whole block could be replaced with:
context->log_with_destination(level, message.value(), dest.value());
src/exports.cc
Outdated
| if (!dest) { | ||
| return WasmResult::InvalidMemoryAccess; | ||
| } | ||
| context->log(level, dest.value()); |
There was a problem hiding this comment.
yes. thanks for catching
Signed-off-by: Vikas Choudhary <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements proxy-wasm/spec#38.
@PiotrSikora @mathetake @anuraaga please see if going in right direction overall. Will add unit tests once confirmed.
I have tested the changes manually. Related changes in envoy, envoyproxy/envoy#26364
xref: envoyproxy/envoy#22669