Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump v8 version to fix llvm-14 build issues #377

Closed
wants to merge 1 commit into from
Closed

Bump v8 version to fix llvm-14 build issues #377

wants to merge 1 commit into from

Conversation

martijneken
Copy link
Contributor 

$ bazelisk build //test:wasm_vm_test --define engine=v8 --config=clang
...
In file included from external/v8/src/base/vlq-base64.cc:8:
external/v8/src/base/logging.h:154:26: error: use of undeclared identifier 'uint16_t'
                         uint16_t> >;
                         ^
external/v8/src/base/logging.h:155:22: error: unknown type name 'int_t'
  return static_cast<int_t>(static_cast<underlying_t>(val));
                     ^

@martijneken
Bump v8 version to fix llvm-14 build issues
4bd834d 
```
$ bazelisk build //test:wasm_vm_test --define engine=v8 --config=clang
...
In file included from external/v8/src/base/vlq-base64.cc:8:
external/v8/src/base/logging.h:154:26: error: use of undeclared identifier 'uint16_t'
                         uint16_t> >;
                         ^
external/v8/src/base/logging.h:155:22: error: unknown type name 'int_t'
  return static_cast<int_t>(static_cast<underlying_t>(val));
                     ^
```

Signed-off-by: Martijn Stevenson <[email protected]>
@martijneken
Copy link
Contributor Author

Sigh. Will probably abandon this in favor of a patch like envoyproxy/envoy#29425

@PiotrSikora
Copy link
Member

Wouldn't this be resolved by #369? cc @mpwarres

@martijneken
Copy link
Contributor Author

Wouldn't this be resolved by #369? cc @mpwarres

Looks like it, wasn't aware of that. Closing this.

@martijneken martijneken deleted the bump-v8 branch January 29, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PiotrSikora PiotrSikora Awaiting requested review from PiotrSikora

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martijneken @PiotrSikora