chore: bump rules_python and rules_fuzzing #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martijneken
changed the title
martijneken
changed the title
Do we need all 3 phases? Could it be 2? Note that this leaks into dependent projects (i.e. Envoy). |
PiotrSikora
reviewed
Aug 9, 2024
It cannot be 2:
ACK, it's unfortunate. Envoy should be easy since it has matching/more phases. Longer term bzlmod will fix all of this? |
This requires extracting WORKSPACE phases into more phases: - dependencies -- py_repositories() and toolchains - dependencies_python() -- pip_parse module loading - dependencies_import() -- python/fuzzing/other deps The new structure roughly matches Envoy WORKSPACE: - envoy_dependencies() - envoy_dependencies_extra() -- not needed here - envoy_python_dependencies() - envoy_dependency_imports() Signed-off-by: Martijn Stevenson <[email protected]>
Signed-off-by: Martijn Stevenson <[email protected]>
This addresses a `getsectdatafromheader_64` build error Signed-off-by: Martijn Stevenson <[email protected]>
martijneken
force-pushed
the
bump-bazel-rules
branch
from
adb9e42 to
c68032e
Compare
PiotrSikora
reviewed
Aug 12, 2024
mpwarres
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes macOS CI #384
Upgrade rules_python (0.34.0) and rules_fuzzing (0.5.2)
This requires extracting more WORKSPACE phases:
The new structure roughly matches Envoy WORKSPACE: