Skip to content

Commit

Permalink
Update MSRV to Rust v1.64.0. (#252)
Browse files Browse the repository at this point in the history
Technically, this happened as a result of hashbrown update in #195,
but we didn't catch it at the time.

Add tests using MSRV to prevent this from happening in the future.

Signed-off-by: Piotr Sikora <[email protected]>
  • Loading branch information
PiotrSikora authored Jul 30, 2024
1 parent 1109769 commit 3f4274e
Show file tree
Hide file tree
Showing 2 changed files with 52 additions and 3 deletions.
53 changes: 51 additions & 2 deletions .github/workflows/rust.yml
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,55 @@ jobs:
bazelisk --noworkspace_rc run --noenable_bzlmod //bazel/cargo:crates_vendor
git diff --exit-code
msrv:
runs-on: ubuntu-latest

env:
RUSTFLAGS: -D warnings

steps:
- uses: actions/checkout@v2

- name: Install dependencies
if: ${{ env.ACT }}
run: |
curl -OL https://static.rust-lang.org/rustup/rustup-init.sh
chmod +x ./rustup-init.sh
./rustup-init.sh -y --default-toolchain 1.64.0
rm rustup-init.sh
echo "$HOME/.cargo/bin" >> $GITHUB_PATH
- name: Update Rust
run: |
rustup toolchain install 1.64.0 --component clippy --component rustfmt
rustup default 1.64.0
rustup target add wasm32-unknown-unknown
rustup target add wasm32-wasi
- name: Build (wasm32-unknown-unknown)
run: cargo build --release --all-targets --target=wasm32-unknown-unknown

- name: Clippy (wasm32-unknown-unknown)
run: cargo clippy --release --all-targets --target=wasm32-unknown-unknown

- name: Build (wasm32-wasi)
run: cargo build --release --all-targets --target=wasm32-wasi

- name: Clippy (wasm32-wasi)
run: cargo clippy --release --all-targets --target=wasm32-wasi

- name: Format (rustfmt)
run: cargo fmt -- --check

- name: Format (manifest)
run: cargo verify-project

- name: Package (docs)
run: cargo doc --no-deps --target=wasm32-unknown-unknown

- name: Package (publish)
run: cargo publish --dry-run --target=wasm32-unknown-unknown

stable:
runs-on: ubuntu-latest

Expand Down Expand Up @@ -157,9 +206,9 @@ jobs:
- name: Update Rust
run: |
rustup toolchain install nightly --component clippy --component rustfmt
rustup +nightly target add wasm32-unknown-unknown
rustup +nightly target add wasm32-wasi
rustup default nightly
rustup target add wasm32-unknown-unknown
rustup target add wasm32-wasi
- name: Build (wasm32-unknown-unknown)
run: cargo build --release --all-targets --target=wasm32-unknown-unknown
Expand Down
2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
name = "proxy-wasm"
version = "0.2.2"
authors = ["Piotr Sikora <[email protected]>"]
rust-version = "1.61"
rust-version = "1.64"
description = "WebAssembly for Proxies"
readme = "README.md"
license = "Apache-2.0"
Expand Down

0 comments on commit 3f4274e

Please sign in to comment.