Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conditional attributes in exported allocator name. #299

Merged
merged 3 commits into from
Jan 15, 2025

Conversation

PiotrSikora
Copy link
Member

#[export_name] already takes precedence over #[no_mangle],
so this is a no-op, but it silences the warning.

Found with nightly.

`#[export_name]` already takes precedence over `#[no_mangle]`,
so this is a no-op, but it silences the warning.

Found with nightly.

Signed-off-by: Piotr Sikora <[email protected]>
Copy link

@leonm1 leonm1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix, thanks for sending a PR!

@PiotrSikora PiotrSikora merged commit c502d38 into proxy-wasm:main Jan 15, 2025
21 checks passed
@PiotrSikora PiotrSikora deleted the allocator-export-name branch January 15, 2025 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants