Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Az migrate init infra #40

Open
wants to merge 10 commits into
base: AzMigrateBugFix
Choose a base branch
from
Open

Az migrate init infra #40

wants to merge 10 commits into from

Conversation

prsadhu-ms-idc
Copy link
Owner

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

vaindana
vaindana reviewed Oct 8, 2020
View reviewed changes
src/Migrate/deploymentscripts/Initialize-AzMigrateReplicationInfrastructure.ps1 Outdated
$mappingName = "containermapping"
$allFabrics = Get-AzMigrateReplicationFabric -ResourceGroupName $ResourceGroupName -ResourceName $VaultName
foreach($fabric in $allFabrics){
if($fabric.Name -match $applianceName){
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fabric contains vmwareSiteId/physicalSiteId properties. you have to use them to identify right fabric instead appliance name match which is a hacky approach.

Copy link
Owner Author

@prsadhu-ms-idc prsadhu-ms-idc Oct 9, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed it in other codes as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaindana vaindana vaindana left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prsadhu-ms-idc @vaindana