Skip to content

feat: Support generics. #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

itsdevbear
Copy link
Contributor

Useful, safe and I don't really see any downsides.

itsdevbear added 3 commits April 15, 2024 20:52
@CLAassistant
Copy link

CLAassistant commented Apr 16, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


itsdevbear seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@itsdevbear
Copy link
Contributor Author

@potuz

@potuz
Copy link
Collaborator

potuz commented May 8, 2024

Apologies for the delay, got dug in mailbox for some reason. I assume the usecase you want is to have flat byte slices for usecases? I agree this may be a cleaner solution. Could you add unit tests that check for both these paths with [][32]byte and []byte as arguments? As a plus, if you could provide benches on both attached to this PR that'd be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants