-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update p2p metaData
file when it is changed
#14401
Open
syjn99
wants to merge
13
commits into
prysmaticlabs:develop
Choose a base branch
from
syjn99:fix/p2p-metadata
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syjn99
changed the title
fix: update
fix: update p2p Aug 30, 2024
metaData
file when it is changedmetaData
file when it is changed
Thanks for you PR, will look. |
@nalepae |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
This PR addresses Issue #13586, where the beacon-chain does not update the
metaData
file as expected. The issue arises because there is currently no code to write to themetaData
file after initialization. As a result, the sequence number stored on disk always remains zero. This behavior is acceptable when the--p2p-static-id
flag is not provided. However, it causes significant issues in the P2P processes when a user intends to maintain the same peer ID across sessions. (especially when ping to peers, but those peers found that the sequence number of sender is lower than they manage in their own tables.)Which issues(s) does this PR fix?
Fixes #13586
Other notes for review
migrateFromProtoToSsz
) in case user hasmetaData
file already.Acknowledgements