small improvements to logs #14405
Merged
small improvements to logs #14405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-prysm
changed the title
james-prysm
commented
Oct 29, 2024
validator/client/service.go
Outdated
| @@ -292,9 +292,6 @@ func ConstructDialOptions( | |||
| transportSecurity = grpc.WithTransportCredentials(creds) | |||
| } else { | |||
| transportSecurity = grpc.WithInsecure() | |||
| log.Warn("You are using an insecure gRPC connection. If you are running your beacon node and " + | |||
There was a problem hiding this comment.
putting it back in, fails test + was supposed to do some more setup
james-prysm
commented
Oct 29, 2024
| @@ -159,6 +155,10 @@ func (psl *settingsLoader) Load(cliCtx *cli.Context) (*proposer.Settings, error) | |||
| if psl.options.builderConfig != nil { | |||
| defaultConfig.Builder = psl.options.builderConfig.ToConsensus() | |||
| } | |||
| if psl.existsInDB && len(psl.loadMethods) == 1 { | |||
| // only log the below if default flag is the only load method | |||
There was a problem hiding this comment.
log is a bit noisy, mostly debugging purposes
james-prysm
commented
Oct 29, 2024
| @@ -1327,6 +1327,11 @@ func (v *validator) buildSignedRegReqs( | |||
| if v.genesisTime > uint64(time.Now().UTC().Unix()) { | |||
| return signedValRegRequests | |||
| } | |||
|
|
|||
| if v.ProposerSettings().DefaultConfig != nil && v.ProposerSettings().DefaultConfig.FeeRecipientConfig == nil && v.ProposerSettings().DefaultConfig.BuilderConfig != nil { | |||
There was a problem hiding this comment.
printing too much in loop
terencechain
previously approved these changes
Oct 29, 2024
terencechain
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
removes some duplicate logs, or moves them to be less redudnant
Which issues(s) does this PR fix?
Fixes #
Other notes for review
Acknowledgements