Fix lc execution header bug #14468
Merged
Fix lc execution header bug #14468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
rkapka
reviewed
Oct 2, 2024
Co-authored-by: Radosław Kapka <[email protected]>
Co-authored-by: Radosław Kapka <[email protected]>
Co-authored-by: Radosław Kapka <[email protected]>
rkapka
previously approved these changes
Oct 2, 2024
auto-merge was automatically disabled
October 2, 2024 23:28
Head branch was pushed to by a user without write access
rkapka
approved these changes
Oct 3, 2024
Merged
via the queue into
prysmaticlabs:develop
with commit Oct 3, 2024
6af44a1
22 of 23 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be reviewed after #14457 is merged.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
This PR fixes a bug in
core/light-clientwhere theupdate.AttestedHeader.Executionandupdate.AttestedHeader.ExecutionBranchwere being created based on currentBlockand notAttestedBlock.specifically:
AttestedHeader.ExecutionandAttestedHeader.ExecutionBranch.AttestedBlockinput parameter to theCreateNewLightClientUpdate,CreateNewLightClientOptimisticUpdate, andCreateNewLightClientFinalityUpdatein thecore/light-client.AttestedBlockinput parameter to the same functions above, but inRPC/eth/light-client.AttestedBlockfrom the LC handlers through to thecorepackage.BlockToLightClientHeaderfunction instead of calculating the headers manually incore/light-clientCreateNewLightClientUpdatefunction.Which issues(s) does this PR fix?
This PR is needed as part of #12991