validator REST: attestation v2 #14633
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-prysm
commented
Nov 7, 2024
james-prysm
commented
Nov 8, 2024
james-prysm
commented
Nov 8, 2024
| return nil, errors.Wrap(err, "failed to get attestation data") | ||
| } | ||
|
|
||
| signature, err := hexutil.Decode(jsonAttestation.Signature) |
There was a problem hiding this comment.
should we be checking for lengths?
james-prysm
commented
Nov 8, 2024
validator/client/beacon-api/submit_aggregate_selection_proof_test.go
Outdated
Show resolved
Hide resolved
saolyn
reviewed
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
added the use of the following endpoints for validator rest mode to support the Electra hardfork
/eth/v2/beacon/pool/attestationsPOST/eth/v2/validator/aggregate_and_proofsPOST/eth/v2/validator/aggregate_attestationGETWhich issues(s) does this PR fix?
Fixes #
Other notes for review
Acknowledgements