Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Engine Capabilites Check #14924

Merged
merged 2 commits into from
Feb 13, 2025
Merged

Fix Engine Capabilites Check #14924

merged 2 commits into from
Feb 13, 2025

Conversation

nisdas
Copy link
Member

@nisdas nisdas commented Feb 13, 2025

What type of PR is this?

Bug Fix

What does this PR do? Why is it needed?

We only check for electra related engine methods if the fork is active

Which issues(s) does this PR fix?

Fixes #14923

Other notes for review

Acknowledgements

@nisdas nisdas added the Electra electra hardfork label Feb 13, 2025
@nisdas nisdas requested a review from a team as a code owner February 13, 2025 12:28
@nisdas nisdas requested review from saolyn, potuz and rkapka February 13, 2025 12:28
Copy link
Contributor

@saolyn saolyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nisdas nisdas added this pull request to the merge queue Feb 13, 2025
Merged via the queue into develop with commit 3eec5a5 Feb 13, 2025
17 checks passed
@nisdas nisdas deleted the fixCapabilitiesCheck branch February 13, 2025 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Electra electra hardfork
Projects
None yet
Development

Successfully merging this pull request may close these issues.

engine_exchangeCapabilities Nethermind<>Prysm warning, Please update client
2 participants