Cell proof #15064
Open
Cell proof #15064
+4,904
−1,669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x00101010
requested review from
nisdas,
Inspector-Butters and
james-prysm
and removed request for
a team
nalepae
reviewed
Mar 28, 2025
| @@ -689,3 +689,37 @@ func (sigBlock *SignedBeaconBlockFulu) Copy() *SignedBeaconBlockFulu { | |||
| Signature: bytesutil.SafeCopyBytes(sigBlock.Signature), | |||
| } | |||
| } | |||
|
|
|||
| func (block *BeaconBlockFulu) Copy() *BeaconBlockFulu { | |||
There was a problem hiding this comment.
Can't we re-use BeaconBlockElectra?
|
|
||
| // 96 byte BLS signature from the validator that produced this block. | ||
| bytes signature = 2 [ (ethereum.eth.ext.ssz_size) = "96" ]; | ||
| } | ||
|
|
||
| message BeaconBlockContentsFulu { | ||
| BeaconBlockElectra block = 1; | ||
| BeaconBlockFulu block = 1; |
There was a problem hiding this comment.
Can't we re-use BeaconBlockElectra?
| ]; | ||
| repeated bytes blobs = 3 [ | ||
| (ethereum.eth.ext.ssz_size) = "?,blob.size", | ||
| (ethereum.eth.ext.ssz_max) = "4096" | ||
| ]; | ||
| } | ||
|
|
||
| message BeaconBlockFulu { |
There was a problem hiding this comment.
Can't we re-use BeaconBlockElectra?
| BeaconBlockBodyFulu body = 5; | ||
| } | ||
|
|
||
| message BeaconBlockBodyFulu { |
There was a problem hiding this comment.
Can't we re-use BeaconBlockBodyElectra?
nalepae
reviewed
Mar 28, 2025
| } | ||
|
|
||
| // Get the block body. | ||
| start := time.Now() |
There was a problem hiding this comment.
To be strictly fair this should be the first line of the function.
| startTime := time.Now() | ||
| blobsCount := len(blobs) | ||
| if blobsCount == 0 { | ||
| func DataColumnSidecars(signedBlock interfaces.ReadOnlySignedBeaconBlock, cellsAndProofs []kzg.CellsAndProofs) ([]*ethpb.DataColumnSidecar, error) { |
There was a problem hiding this comment.
The godoc is not correct any more.
| "github.com/prysmaticlabs/prysm/v5/runtime/version" | ||
| ) | ||
|
|
||
| // Helper function to unblind data column sidecars from a block and a blobs bundle v2. |
There was a problem hiding this comment.
Godoc of public function should start with the name of the public function itself.
| return DataColumnSidecars(block, cellsAndProofs) | ||
| } | ||
|
|
||
| func ConstructCellsAndProofs(blobs [][]byte, cellProofs [][]byte) ([]kzg.CellsAndProofs, error) { |
There was a problem hiding this comment.
Does this function need to be public?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
New cell proof computation related changes as defined in:
Which issues(s) does this PR fix?
#14129
Fixes #
Other notes for review
Acknowledgements