Don't call reflect.ValueOf(msg) twice

Closes: #94 [via git-merge-pr]
psanford · Oct 24, 2023 · 68dc344 · 68dc344
1 parent 1bb058c
commit 68dc344
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/wormhole/wormhole.go b/wormhole/wormhole.go
@@ -332,9 +332,11 @@ func (c *msgCollector) closeWithErr(err error) {
 }
 
 func (c *msgCollector) waitFor(msg collectable) error {
-	if reflect.ValueOf(msg).Kind() != reflect.Ptr {
+	msgValue := reflect.ValueOf(msg)
+	if msgValue.Kind() != reflect.Ptr {
 		return errors.New("you must pass waitFor a pointer to a struct")
 	}
+
 	sub := collectSubscription{
 		collectMsg: msg,
 		result:     make(chan collectResult, 1),
@@ -354,7 +356,7 @@ func (c *msgCollector) waitFor(msg collectable) error {
 		return result.err
 	}
 
-	dst := reflect.ValueOf(msg).Elem()
+	dst := msgValue.Elem()
 	src := reflect.ValueOf(result.result).Elem()
 
 	dst.Set(src)