Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IO fixes (tfield; checkpoint) #319

Closed
wants to merge 31 commits into from
Closed

IO fixes (tfield; checkpoint) #319

wants to merge 31 commits into from

Conversation

liangwang0734
Copy link
Contributor

@liangwang0734 liangwang0734 commented Jun 30, 2023

  • fix tfield logic
  • support bp5 for checkpoint and TestIOAdios

liangwang-phys and others added 28 commits June 30, 2023 23:07
to reuse the IOAdios2 object

seems to get bp5 checkpointing to work in some cases
checkpoint: remove performPuts as it was suggested against for bp5 in the adios2 doc
may incur a slight slowdown during initialization phase,
but should make things more flexible
this version is a disaster of repeated code, but hopefully works
@liangwang0734
Copy link
Contributor Author

Hi @germasch the only failed check now is spack-psc-cuda-rmm, could you check?

The error says

     32    -- Found rmm: /opt/spack/opt/spack/linux-ubuntu20.04-haswell/gcc-9.3
           .0/rmm-0.18.0-etgejhmfqnv5iccxgjndwssl374eupxt/lib/cmake/rmm/rmm-con
           fig.cmake (found suitable version "0.18.0", minimum required is "0.1
           8.0")
     33    -- Found MPI: TRUE (found version "3.1") found components: C
     34    -- Found HDF5: /usr/lib/x86_64-linux-gnu/hdf5/openmpi/libhdf5.so;/us
           r/lib/x86_64-linux-gnu/libsz.so;/usr/lib/x86_64-linux-gnu/libz.so;/u
           sr/lib/x86_64-linux-gnu/libdl.so;/usr/lib/x86_64-linux-gnu/libm.so (
           found version "1.10.4") found components: C HL
     35    -- Configuring done
  >> 36    CMake Error in src/CMakeLists.txt:
     37      No known features for CUDA compiler
     38    
     39      ""
     40    
     41      version .

@germasch
Copy link
Contributor

@liangwang0734, I think this is mostly superseded by what I just merged. There is one bit in there we should still talk about -- that is, making the io object and the writer persistent, which I didn't merge, because I don't understand why it should be needed, but if you can explain to me why, we can deal with it.

@germasch germasch closed this Jul 25, 2023
@liangwang0734
Copy link
Contributor Author

liangwang0734 commented Jul 25, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants