-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IO fixes (tfield; checkpoint) #319
Conversation
to reuse the IOAdios2 object seems to get bp5 checkpointing to work in some cases
checkpoint: remove performPuts as it was suggested against for bp5 in the adios2 doc
may incur a slight slowdown during initialization phase, but should make things more flexible
this version is a disaster of repeated code, but hopefully works
b85f68b
to
01804a4
Compare
Hi @germasch the only failed check now is The error says
|
@liangwang0734, I think this is mostly superseded by what I just merged. There is one bit in there we should still talk about -- that is, making the io object and the writer persistent, which I didn't merge, because I don't understand why it should be needed, but if you can explain to me why, we can deal with it. |
I made that change when I tried to debug BP5. It's possible it was made
just to avoid repeated io object creation. If all the tests pass then I
assume this commit is not necessary.
…On Tue, Jul 25, 2023, 11:51 AM Kai Germaschewski ***@***.***> wrote:
@liangwang0734 <https://github.com/liangwang0734>, I think this is mostly
superseded by what I just merged. There is one bit in there we should still
talk about -- that is, making the io object and the writer persistent,
which I didn't merge, because I don't understand why it should be needed,
but if you can explain to me why, we can deal with it.
—
Reply to this email directly, view it on GitHub
<#319 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHUIY3P52RRMC7GFGFZVV3XR7TPBANCNFSM6AAAAAAZ2K6VUA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
tfield
logiccheckpoint
andTestIOAdios