-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly fix when OutputFieldsDefault writes output #326
Conversation
JamesMcClung
commented
Sep 6, 2023
- Extract/factor out common behavior of pfield params and tfield params
- Fix behavior of when to do a pfd/tfd write after checkpoint
- Fix behavior of when to accumulate for tfd
- Add comments and generally improve code readability
- Add tests for the above
tfields_average_every is now unused (instead of misused)
this restores its intended functionality
make it clearer that timestep only matters relative to tfield_next_
also simplify/document the process
will still output tfd at t=0 when tfield_first = 0
cf0a76b
to
31b1920
Compare
I'd like to remove Although one unaesthetic thing would be having to do the math in both |
floordiv would also work
31b1920
to
a059e51
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nicely done. I hadn't expected you'd actually do the unit test stuff, but that's great.