Issue #97 fix. Absolute path in transfer #116
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If I want to upload some file for me it's much more obvious to work with absolute paths: local.transfer([path.join(__dirname, '../somefile.sh'), '/log/somefile.txt'], '~/'); |
| @@ -109,7 +109,7 @@ Shell.prototype.transfer = function(files, remoteDir, options) { | |||
| (remote.username ? remote.username + '@' : ''), | |||
| remote.host, remoteDir); | |||
|
|
|||
| var command = util.format('rsync --files-from %s %s --rsh="ssh -p%s%s" ./ %s', | |||
| var command = util.format('cat %s | xargs -n 50 -J % rsync %s --rsh="ssh -p%s%s" % %s', | |||
There was a problem hiding this comment.
A couple of questions:
- Why are you limiting this to 50 files?
- What are the percentage signs doing?
- Is this working with spaces and special characters in file names?
- Is this still working properly with relative paths?
- How does this perform when uploading hundreds of files?
There was a problem hiding this comment.
- It's a chunk limit
- See xargs doc http://charlesreid1.com/wiki/Xargs#-I_vs._-J
- I hope :)
- No, currently... But we can do some algorithm that will transform relative path into absolute. Question only one: what folder should be a "base"?
- It will generate few rsync commands
There was a problem hiding this comment.
- man xargs: "The current default value for number is 5000"
- Please use %% (https://nodejs.org/api/util.html#util_util_format_format)
- Can you verify this?
- This is a requirement.
I think your changes break the current functionality where I can specify an array of files (in different or same directories) and the whole tree is rebuilt inside the remote's target directory.
|
Thanks for your PR. Please check my comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for Issue #97. Now we can use absolute path in
transport.transfer