Merge pull request #521 from psteinroe/fix/delete-single

fix: make delete work on single query
psteinroe · Nov 8, 2024 · 44adffc · 44adffc
2 parents 0df96e2 + b06405b
commit 44adffc
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 1 deletion.
diff --git a/.changeset/cuddly-islands-boil.md b/.changeset/cuddly-islands-boil.md
@@ -0,0 +1,5 @@
+---
+"@supabase-cache-helpers/postgrest-core": patch
+---
+
+fix: make delete work on single query
diff --git a/packages/postgrest-core/src/delete-item.ts b/packages/postgrest-core/src/delete-item.ts
@@ -116,7 +116,16 @@ export const deleteItem = async <KeyType, Type extends Record<string, unknown>>(
               } else if (isAnyPostgrestResponse<Type>(currentData)) {
                 const { data } = currentData;
                 if (!Array.isArray(data)) {
-                  return { data: null };
+                  if (
+                    data &&
+                    op.primaryKeys.some(
+                      (pk) => transformedInput[pk] !== data[pk],
+                    )
+                  ) {
+                    return currentData;
+                  } else {
+                    return { data: null };
+                  }
                 }
 
                 const newData = filterByPks(

diff --git a/packages/postgrest-core/tests/delete-item.spec.ts b/packages/postgrest-core/tests/delete-item.spec.ts
@@ -286,6 +286,18 @@ describe('deleteItem', () => {
     });
   });
 
+  it('should not change data if its single and primary keys do not match', async () => {
+    expect(
+      await mutateFnResult(
+        { id_1: '0', id_2: '1', value: 'a' },
+        {},
+        { data: { id_1: '0', id_2: '0', value: 'test' } },
+      ),
+    ).toMatchObject({
+      data: { id_1: '0', id_2: '0', value: 'test' },
+    });
+  });
+
   it('should delete item from cached array and subtract count', async () => {
     expect(
       await mutateFnResult(