Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ci #33

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from
Draft

Fix ci #33

wants to merge 4 commits into from

Conversation

Chilipp
Copy link
Member

@Chilipp Chilipp commented Jul 24, 2023

this PR aims to fix the CI builds and make some compatibility fixes

see psyplot/psyplot#58

Closes #32 (remove if there is no corresponding issue, which should only be the case for minor changes)

  • Tests added (for all bug fixes or enhancements)
  • Tests passed (for all non-documentation changes)
  • Fully documented, including CHANGELOG.rst for all changes

@Chilipp Chilipp self-assigned this Jul 24, 2023
@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (227d84e) 78.09% compared to head (0dc9bc1) 78.16%.

❗ Current head 0dc9bc1 differs from pull request most recent head cf82b53. Consider uploading reports for the commit cf82b53 to get more accurate results

Files Patch % Lines
psyplot_gui/backend.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #33      +/-   ##
===========================================
+ Coverage    78.09%   78.16%   +0.07%     
===========================================
  Files           17       17              
  Lines         5190     5198       +8     
===========================================
+ Hits          4053     4063      +10     
+ Misses        1137     1135       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AttributeError: 'PsyplotCanvasManager' object has no attribute '_get_toolbar'
1 participant